Skip to content

Commit d7a5d64

Browse files
authored
Add ruff warning for new colorama usage (aws#10085)
1 parent 521a997 commit d7a5d64

6 files changed

Lines changed: 8 additions & 5 deletions

File tree

awscli/customizations/ecs/expressgateway/color_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
"""Color utilities for ECS Express Gateway Service monitoring."""
1515

16-
from colorama import Fore, Style, init
16+
from colorama import Fore, Style, init # noqa
1717

1818
# Status symbols
1919
CHECK_MARK = '✓'

awscli/customizations/history/show.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ def __init__(self, output=None, include=None, exclude=None, colorize=True):
157157
self._colorize = colorize
158158
self._value_pformatter = SectionValuePrettyFormatter()
159159
if self._colorize:
160-
colorama.init(**COLORAMA_KWARGS)
160+
colorama.init(**COLORAMA_KWARGS) # noqa
161161

162162
def _display(self, event_record):
163163
section_definition = self._SECTIONS.get(event_record['event_type'])

awscli/customizations/logs/startlivetail.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,7 @@ def __init__(
543543
self._is_sampled = False
544544
self._keywords_to_highlight = keywords_to_highlight
545545
self._format = OutputFormat.JSON
546-
colorama.init(autoreset=True, strip=False)
546+
colorama.init(autoreset=True, strip=False) # noqa
547547

548548
@property
549549
def log_events_displayed(self):

awscli/customizations/logs/tail.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def __init__(self, output, colorize=True):
3333
self._output = output
3434
self._colorize = colorize
3535
if self._colorize:
36-
colorama.init(autoreset=True, strip=False)
36+
colorama.init(autoreset=True, strip=False) # noqa
3737

3838
def display_log_event(self, log_event):
3939
raise NotImplementedError('display_log_event()')

awscli/table.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ def style_indentation_char(self, text):
175175

176176
class ColorizedStyler(Styler):
177177
def __init__(self):
178-
colorama.init(**COLORAMA_KWARGS)
178+
colorama.init(**COLORAMA_KWARGS) # noqa
179179

180180
def style_title(self, text):
181181
# Originally bold + underline

pyproject.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,3 +192,6 @@ line-ending = "auto"
192192

193193
docstring-code-format = false
194194
docstring-code-line-length = "dynamic"
195+
196+
[tool.ruff.lint.flake8-tidy-imports.banned-api]
197+
"colorama.init".msg = "Ensure you call colorama.init() only when invoking a command that uses it, and not on import. See https://github.com/aws/aws-cli/issues/9864"

0 commit comments

Comments
 (0)