v2.5 brand_manifest as inline object (not URL) is unhandled by legacy adapter

[bokelley]

Background

Surfaced during expert review of #679. Pre-existing gap, not introduced by that PR.

The v2.5 brand-manifest-ref schema (schemas/cache/2.5/core/brand-manifest-ref.json) defines brand_manifest as:

oneOf:
  - BrandManifest object   # inline object
  - URL string             # reference URL

Both branches are spec-compliant v2.5 input.

Impact

The current adapter only handles the string branch:

src/adcp/compat/legacy/v2_5/get_products.py:130:

brand_manifest = out.pop(\"brand_manifest\", None)
if isinstance(brand_manifest, str) and brand_manifest and \"brand\" not in out:
    out[\"brand\"] = {\"domain\": extract_brand_domain(brand_manifest)}

And the matching helper at src/adcp/compat/legacy/v2_5/_media_buy_helpers.py (used by create_media_buy) has the same guard.

When a v2.5 buyer sends an inline brand_manifest object, the field is popped (so it won't survive into v3), but brand is never populated either — the request goes through with no brand at all, which then fails v3 validation if brand is required, or silently advertises no brand if it isn't.

Suggested fix

Handle the dict branch — extract the hostname from the inline object's URL field (whatever the v2.5 BrandManifest schema names it), or if the inline object has no derivable hostname, raise a typed translation error so the buyer gets a clear INVALID_REQUEST[brand_manifest] rather than a confusing downstream regex failure or silent drop.

Both call sites need the fix:

• src/adcp/compat/legacy/v2_5/get_products.py:adapt_request
• src/adcp/compat/legacy/v2_5/_media_buy_helpers.py:adapt_brand_manifest_to_brand (used by create_media_buy)

[bokelley]

Triage

Classification: Bug
Bucket(s): client (compat/legacy adapter in src/adcp/compat/legacy/v2_5/)
Status: drafting-pr
Milestone: —

What the experts said:

• code-reviewer: approved — elif isinstance(dict) branch is correct; url.strip() guard prevents whitespace-only url from producing {"domain": ""} (fixed before PR creation); nits on module docstrings and mutation-safety test coverage
• ad-tech-protocol-expert: approved — oneOf handling matches spec; silent-skip for no-url is the only defensible behavior; nit on asymmetric required-field behavior between create_media_buy (where v3 brand is required) and get_products (where it's optional)
• dx-expert (plan review): confirmed that raising on url-absent input would reject spec-valid {"name": "Great Value"} payloads — silent-skip is correct

My take: Pre-existing gap, not introduced by #679. The fix adds the dict branch at both call sites, guards on url.strip(), and treats no-url as a silent pass-through (let v3 validation decide). 8 new tests added; all 52 pass. Draft PR opened as #685.

Drafted PR: #685

---

Triaged by Claude Code. Session: https://claude.ai/code/session_01Nz3E58qfSW4X6fdJngTxKt

---

Generated by Claude Code