Skip to content

decisioning: align hello_seller.py with validate_platform soft-warn surface #515

@bokelley

Description

@bokelley

From the salesagent v3.12 → 4.x migration (SDK_FEEDBACK.md, item #9).

hello_seller.py implements 5 methods. Running validate_platform against it warns about 4 additional missing methods that are "required by the SalesPlatform Protocol for any sales-* specialism in v6.0 rc.1+":

  • get_media_buys
  • list_creative_formats
  • list_creatives
  • provide_performance_feedback

Adopter quote:

The canonical minimal example trips the soft-warn. Either the example should implement them, or the warning's threshold is wrong.

Decision needed

Pick one:

  • Expand the example. Update hello_seller.py to implement the 9-method minimum surface. Forces adopters to see the full required shape from the start.
  • Relax the warn threshold. Decide which subset is genuinely required for sales-non-guaranteed and only soft-warn on those. Keep hello_seller.py minimal as the on-ramp.

The signal-mismatch is the bug. Code change scoped to examples/hello_seller.py OR src/adcp/decisioning/specialisms/sales.py depending on the call.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions