Commit c9ea04e
ci(storyboard): vendor AAO reference-formats fixture into @adcp/sdk install
Three of the four storyboard runners (seller_agent.py, sales-proposal-mode,
v3 reference seller (translator)) have been failing on main and on every
PR for the same upstream reason: ``@adcp/sdk@latest`` (which the storyboard
jobs install unpinned for drift-detection) does not ship
``aao-reference-formats.json`` in its npm tarball. Every step that
touches AAO format resolution rejects with:
AAO catalog (reference-formats.json) not found. Looked in:
.../node_modules/@adcp/sdk/test/lib/v2-projection-fixtures/aao-reference-formats.json
.../node_modules/@adcp/sdk/.context/adcp-3307/server/src/creative-agent/reference-formats.json
Vendor a copy at test/lib/v2-projection-fixtures/aao-reference-formats.json.
The SDK's error message itself recommends vendoring the file at the
expected path. Upstream tracking issue is adcp#3307.
Fix:
- Vendor the file at ``tests/fixtures/aao-reference-formats.json``
(sourced from ``adcontextprotocol/adcp:server/src/creative-agent/reference-formats.json``,
the canonical reference catalog the SDK is supposed to ship).
- Add three lines to each of the four storyboard jobs' ``Pre-install
@adcp/sdk`` steps to drop the file into
``$(npm root -g)/@adcp/sdk/test/lib/v2-projection-fixtures/`` after
the npm install. Idempotent — if upstream later ships the file the
``cp`` overwrites with the same bytes; if upstream moves it the
overwrite is a safer floor than the missing-file failure.
The four storyboard jobs affected:
- AdCP storyboard runner — examples/seller_agent.py
- AdCP storyboard runner — examples/multi_platform_seller (PlatformRouter)
(currently passing — doesn't exercise the AAO path — but covered for
symmetry against future drift)
- AdCP storyboard runner — v3 reference seller (translator)
- AdCP storyboard runner — sales-proposal-mode (proposal_finalize)
The vendored file is 145 KiB JSON with 50 format entries. Not committed
to the package distribution (lives under ``tests/fixtures/``).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent c0ed690 commit c9ea04e
2 files changed
Lines changed: 5273 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
391 | 391 | | |
392 | 392 | | |
393 | 393 | | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
394 | 404 | | |
395 | 405 | | |
396 | 406 | | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
397 | 410 | | |
398 | 411 | | |
399 | 412 | | |
| |||
548 | 561 | | |
549 | 562 | | |
550 | 563 | | |
| 564 | + | |
| 565 | + | |
551 | 566 | | |
552 | 567 | | |
553 | 568 | | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
554 | 572 | | |
555 | 573 | | |
556 | 574 | | |
| |||
757 | 775 | | |
758 | 776 | | |
759 | 777 | | |
| 778 | + | |
| 779 | + | |
760 | 780 | | |
761 | 781 | | |
762 | 782 | | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
763 | 786 | | |
764 | 787 | | |
765 | 788 | | |
| |||
858 | 881 | | |
859 | 882 | | |
860 | 883 | | |
| 884 | + | |
| 885 | + | |
861 | 886 | | |
862 | 887 | | |
863 | 888 | | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
864 | 892 | | |
865 | 893 | | |
866 | 894 | | |
| |||
0 commit comments