Skip to content

Commit c9ea04e

Browse files
bokelleyclaude
andcommitted
ci(storyboard): vendor AAO reference-formats fixture into @adcp/sdk install
Three of the four storyboard runners (seller_agent.py, sales-proposal-mode, v3 reference seller (translator)) have been failing on main and on every PR for the same upstream reason: ``@adcp/sdk@latest`` (which the storyboard jobs install unpinned for drift-detection) does not ship ``aao-reference-formats.json`` in its npm tarball. Every step that touches AAO format resolution rejects with: AAO catalog (reference-formats.json) not found. Looked in: .../node_modules/@adcp/sdk/test/lib/v2-projection-fixtures/aao-reference-formats.json .../node_modules/@adcp/sdk/.context/adcp-3307/server/src/creative-agent/reference-formats.json Vendor a copy at test/lib/v2-projection-fixtures/aao-reference-formats.json. The SDK's error message itself recommends vendoring the file at the expected path. Upstream tracking issue is adcp#3307. Fix: - Vendor the file at ``tests/fixtures/aao-reference-formats.json`` (sourced from ``adcontextprotocol/adcp:server/src/creative-agent/reference-formats.json``, the canonical reference catalog the SDK is supposed to ship). - Add three lines to each of the four storyboard jobs' ``Pre-install @adcp/sdk`` steps to drop the file into ``$(npm root -g)/@adcp/sdk/test/lib/v2-projection-fixtures/`` after the npm install. Idempotent — if upstream later ships the file the ``cp`` overwrites with the same bytes; if upstream moves it the overwrite is a safer floor than the missing-file failure. The four storyboard jobs affected: - AdCP storyboard runner — examples/seller_agent.py - AdCP storyboard runner — examples/multi_platform_seller (PlatformRouter) (currently passing — doesn't exercise the AAO path — but covered for symmetry against future drift) - AdCP storyboard runner — v3 reference seller (translator) - AdCP storyboard runner — sales-proposal-mode (proposal_finalize) The vendored file is 145 KiB JSON with 50 format entries. Not committed to the package distribution (lives under ``tests/fixtures/``). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent c0ed690 commit c9ea04e

2 files changed

Lines changed: 5273 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -391,9 +391,22 @@ jobs:
391391
# own CI running AdCP's own canonical runner — tracking latest
392392
# surfaces protocol drift as soon as it ships, which is the
393393
# point of this job.
394+
#
395+
# Vendor the AAO reference-formats fixture into the SDK install:
396+
# ``@adcp/sdk`` does not ship ``aao-reference-formats.json`` in
397+
# its npm tarball (upstream adcontextprotocol/adcp#3307), so the
398+
# AAO catalog lookup fails for every storyboard step that touches
399+
# creative-format resolution. The SDK's own error message
400+
# recommends vendoring the file at this exact path. We keep a
401+
# copy under ``tests/fixtures/`` and drop it into the SDK's
402+
# expected location post-install; idempotent if upstream later
403+
# ships it.
394404
run: |
395405
npm install -g @adcp/sdk@latest
396406
adcp --version
407+
SDK_FIXTURE_DIR="$(npm root -g)/@adcp/sdk/test/lib/v2-projection-fixtures"
408+
mkdir -p "${SDK_FIXTURE_DIR}"
409+
cp tests/fixtures/aao-reference-formats.json "${SDK_FIXTURE_DIR}/aao-reference-formats.json"
397410
398411
- name: Install dependencies
399412
run: |
@@ -548,9 +561,14 @@ jobs:
548561
pip install "sqlalchemy>=2.0" "asyncpg>=0.29" "respx>=0.20"
549562
550563
- name: Pre-install @adcp/sdk (once, then call binary directly)
564+
# See the comment on the storyboard job's install step for the
565+
# AAO reference-formats fixture rationale (upstream adcp#3307).
551566
run: |
552567
npm install -g @adcp/sdk@latest
553568
adcp --version
569+
SDK_FIXTURE_DIR="$(npm root -g)/@adcp/sdk/test/lib/v2-projection-fixtures"
570+
mkdir -p "${SDK_FIXTURE_DIR}"
571+
cp tests/fixtures/aao-reference-formats.json "${SDK_FIXTURE_DIR}/aao-reference-formats.json"
554572
555573
- name: Start JS mock-server upstream
556574
run: |
@@ -757,9 +775,14 @@ jobs:
757775
${{ runner.os }}-npm-
758776
759777
- name: Pre-install @adcp/sdk
778+
# See the comment on the storyboard job's install step for the
779+
# AAO reference-formats fixture rationale (upstream adcp#3307).
760780
run: |
761781
npm install -g @adcp/sdk@latest
762782
adcp --version
783+
SDK_FIXTURE_DIR="$(npm root -g)/@adcp/sdk/test/lib/v2-projection-fixtures"
784+
mkdir -p "${SDK_FIXTURE_DIR}"
785+
cp tests/fixtures/aao-reference-formats.json "${SDK_FIXTURE_DIR}/aao-reference-formats.json"
763786
764787
- name: Install dependencies
765788
run: |
@@ -858,9 +881,14 @@ jobs:
858881
${{ runner.os }}-npm-
859882
860883
- name: Pre-install @adcp/sdk
884+
# See the comment on the storyboard job's install step for the
885+
# AAO reference-formats fixture rationale (upstream adcp#3307).
861886
run: |
862887
npm install -g @adcp/sdk@latest
863888
adcp --version
889+
SDK_FIXTURE_DIR="$(npm root -g)/@adcp/sdk/test/lib/v2-projection-fixtures"
890+
mkdir -p "${SDK_FIXTURE_DIR}"
891+
cp tests/fixtures/aao-reference-formats.json "${SDK_FIXTURE_DIR}/aao-reference-formats.json"
864892
865893
- name: Install dependencies
866894
run: |

0 commit comments

Comments
 (0)