fix: resolve all mypy type checking errors

- Add missing type definitions (FormatId, PackageRequest, etc.) as type aliases in generated.py
- Add type annotations to A2AAdapter.__init__
- Add proper imports to tasks.py from generated.py
- Add type casts for json.load/json.loads to satisfy mypy no-any-return checks
- Update generator to include missing schema type aliases

Fixes all 67 mypy errors across the codebase. All 15 source files now pass type checking.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: bokelley

scripts/generate_models_simple.py

@@ -73,6 +73,19 @@ def generate_model_for_schema(schema_file: Path) -> str:
 
     # Start with model name
     model_name = snake_to_pascal(schema_file.stem)
+
+    # Check if this is a simple type alias (enum or primitive type without properties)
+    if "properties" not in schema:
+        # This is a type alias, not a model class
+        python_type = get_python_type(schema)
+        lines = [f"# Type alias for {schema.get('title', model_name)}"]
+        if "description" in schema:
+            desc = escape_string_for_python(schema["description"])
+            lines.append(f'# {desc}')
+        lines.append(f"{model_name} = {python_type}")
+        return "\n".join(lines)
+
+    # Regular BaseModel class
     lines = [f"class {model_name}(BaseModel):"]
 
     # Add description if available
@@ -85,7 +98,7 @@ def generate_model_for_schema(schema_file: Path) -> str:
         lines.append("")
 
     # Add properties
-    if "properties" not in schema or not schema["properties"]:
+    if not schema["properties"]:
         lines.append("    pass")
         return "\n".join(lines)
 
@@ -244,6 +257,17 @@ def main():
         "protocol-envelope.json",
         "response.json",
         "promoted-products.json",
+        # Enum types (need type aliases)
+        "channels.json",
+        "delivery-type.json",
+        "pacing.json",
+        "package-status.json",
+        "media-buy-status.json",
+        "task-type.json",
+        "task-status.json",
+        "pricing-model.json",
+        "pricing-option.json",
+        "standard-format-ids.json",
     ]
 
     # Find all schemas
@@ -276,6 +300,18 @@ def main():
         "",
         "",
         "# ============================================================================",
+        "# MISSING SCHEMA TYPES (referenced but not provided by upstream)",
+        "# ============================================================================",
+        "",
+        "# These types are referenced in schemas but don't have schema files",
+        "# Defining them as type aliases to maintain type safety",
+        "FormatId = str",
+        "PackageRequest = dict[str, Any]",
+        "PushNotificationConfig = dict[str, Any]",
+        "ReportingCapabilities = dict[str, Any]",
+        "",
+        "",
+        "# ============================================================================",
         "# CORE DOMAIN TYPES",
         "# ============================================================================",
         "",

src/adcp/__main__.py

@@ -8,7 +8,7 @@
 import json
 import sys
 from pathlib import Path
-from typing import Any
+from typing import Any, cast
 
 from adcp.client import ADCPClient
 from adcp.config import (
@@ -83,7 +83,7 @@ def load_payload(payload_arg: str | None) -> dict[str, Any]:
         # Try to read from stdin if available and has data
         if not sys.stdin.isatty():
             try:
-                return json.load(sys.stdin)
+                return cast(dict[str, Any], json.load(sys.stdin))
             except (json.JSONDecodeError, ValueError):
                 pass
         return {}
@@ -94,11 +94,11 @@ def load_payload(payload_arg: str | None) -> dict[str, Any]:
         if not file_path.exists():
             print(f"Error: File not found: {file_path}", file=sys.stderr)
             sys.exit(1)
-        return json.loads(file_path.read_text())
+        return cast(dict[str, Any], json.loads(file_path.read_text()))
 
     # Parse as JSON
     try:
-        return json.loads(payload_arg)
+        return cast(dict[str, Any], json.loads(payload_arg))
     except json.JSONDecodeError as e:
         print(f"Error: Invalid JSON payload: {e}", file=sys.stderr)
         sys.exit(1)
@@ -171,7 +171,7 @@ def resolve_agent_config(agent_identifier: str) -> dict[str, Any]:
     # Check if it's a JSON config
     if agent_identifier.startswith("{"):
         try:
-            return json.loads(agent_identifier)
+            return cast(dict[str, Any], json.loads(agent_identifier))
         except json.JSONDecodeError:
             pass
 

src/adcp/config.py

@@ -4,7 +4,7 @@
 
 import json
 from pathlib import Path
-from typing import Any
+from typing import Any, cast
 
 CONFIG_DIR = Path.home() / ".adcp"
 CONFIG_FILE = CONFIG_DIR / "config.json"
@@ -21,7 +21,7 @@ def load_config() -> dict[str, Any]:
         return {"agents": {}}
 
     with open(CONFIG_FILE) as f:
-        return json.load(f)
+        return cast(dict[str, Any], json.load(f))
 
 
 def save_config(config: dict[str, Any]) -> None:
@@ -60,13 +60,14 @@ def save_agent(
 def get_agent(alias: str) -> dict[str, Any] | None:
     """Get agent configuration by alias."""
     config = load_config()
-    return config.get("agents", {}).get(alias)
+    result = config.get("agents", {}).get(alias)
+    return cast(dict[str, Any], result) if result is not None else None
 
 
 def list_agents() -> dict[str, Any]:
     """List all saved agents."""
     config = load_config()
-    return config.get("agents", {})
+    return cast(dict[str, Any], config.get("agents", {}))
 
 
 def remove_agent(alias: str) -> bool:

src/adcp/protocols/a2a.py

@@ -19,15 +19,15 @@
     ADCPTimeoutError,
 )
 from adcp.protocols.base import ProtocolAdapter
-from adcp.types.core import DebugInfo, TaskResult, TaskStatus
+from adcp.types.core import AgentConfig, DebugInfo, TaskResult, TaskStatus
 
 logger = logging.getLogger(__name__)
 
 
 class A2AAdapter(ProtocolAdapter):
     """Adapter for A2A protocol following the Agent2Agent specification."""
 
-    def __init__(self, agent_config):
+    def __init__(self, agent_config: AgentConfig):
         """Initialize A2A adapter with reusable HTTP client."""
         super().__init__(agent_config)
         self._client: httpx.AsyncClient | None = None

src/adcp/types/generated.py

@@ -16,6 +16,18 @@
 from pydantic import BaseModel, Field
 
 
+# ============================================================================
+# MISSING SCHEMA TYPES (referenced but not provided by upstream)
+# ============================================================================
+
+# These types are referenced in schemas but don't have schema files
+# Defining them as type aliases to maintain type safety
+FormatId = str
+PackageRequest = dict[str, Any]
+PushNotificationConfig = dict[str, Any]
+ReportingCapabilities = dict[str, Any]
+
+
 # ============================================================================
 # CORE DOMAIN TYPES
 # ============================================================================
@@ -111,10 +123,9 @@ class BrandManifest(BaseModel):
     metadata: dict[str, Any] | None = Field(None, description="Additional brand metadata")
 
 
-class BrandManifestRef(BaseModel):
-    """Brand manifest provided either as an inline object or a URL string pointing to a hosted manifest"""
-
-    pass
+# Type alias for Brand Manifest Reference
+# Brand manifest provided either as an inline object or a URL string pointing to a hosted manifest
+BrandManifestRef = Any
 
 
 class Format(BaseModel):
@@ -240,10 +251,9 @@ class PerformanceFeedback(BaseModel):
     applied_at: str | None = Field(None, description="ISO 8601 timestamp when feedback was applied to optimization algorithms")
 
 
-class StartTiming(BaseModel):
-    """Campaign start timing: 'asap' or ISO 8601 date-time"""
-
-    pass
+# Type alias for Start Timing
+# Campaign start timing: 'asap' or ISO 8601 date-time
+StartTiming = Any
 
 
 class SubAsset(BaseModel):
@@ -300,6 +310,56 @@ class PromotedProducts(BaseModel):
     manifest_query: str | None = Field(None, description="Natural language query to select products from the brand manifest (e.g., 'all Kraft Heinz pasta sauces', 'organic products under $20')")
 
 
+# Type alias for Advertising Channels
+# Standard advertising channels supported by AdCP
+Channels = Literal["display", "video", "audio", "native", "dooh", "ctv", "podcast", "retail", "social"]
+
+
+# Type alias for Delivery Type
+# Type of inventory delivery
+DeliveryType = Literal["guaranteed", "non_guaranteed"]
+
+
+# Type alias for Pacing
+# Budget pacing strategy
+Pacing = Literal["even", "asap", "front_loaded"]
+
+
+# Type alias for Package Status
+# Status of a package
+PackageStatus = Literal["draft", "active", "paused", "completed"]
+
+
+# Type alias for Media Buy Status
+# Status of a media buy
+MediaBuyStatus = Literal["pending_activation", "active", "paused", "completed"]
+
+
+# Type alias for Task Type
+# Valid AdCP task types across all domains. These represent the complete set of operations that can be tracked via the task management system.
+TaskType = Literal["create_media_buy", "update_media_buy", "sync_creatives", "activate_signal", "get_signals"]
+
+
+# Type alias for Task Status
+# Standardized task status values based on A2A TaskState enum. Indicates the current state of any AdCP operation.
+TaskStatus = Literal["submitted", "working", "input-required", "completed", "canceled", "failed", "rejected", "auth-required", "unknown"]
+
+
+# Type alias for Pricing Model
+# Supported pricing models for advertising products
+PricingModel = Literal["cpm", "vcpm", "cpc", "cpcv", "cpv", "cpp", "flat_rate"]
+
+
+# Type alias for Pricing Option
+# A pricing model option offered by a publisher for a product. Each pricing model has its own schema with model-specific requirements.
+PricingOption = Any
+
+
+# Type alias for Standard Format IDs
+# Enumeration of all standard creative format identifiers in AdCP
+StandardFormatIds = Literal["display_300x250", "display_728x90", "display_320x50", "display_160x600", "display_970x250", "display_336x280", "display_expandable_300x250", "display_expandable_728x90", "display_interstitial_320x480", "display_interstitial_desktop", "display_dynamic_300x250", "display_responsive", "native_in_feed", "native_content_recommendation", "native_product", "video_skippable_15s", "video_skippable_30s", "video_non_skippable_15s", "video_non_skippable_30s", "video_outstream_autoplay", "video_vertical_story", "video_rewarded_30s", "video_pause_ad", "video_ctv_non_skippable_30s", "audio_standard_15s", "audio_standard_30s", "audio_podcast_host_read", "audio_programmatic", "universal_carousel", "universal_canvas", "universal_takeover", "universal_gallery", "universal_reveal", "dooh_landscape_static", "dooh_portrait_video"]
+
+
 
 # ============================================================================
 # TASK REQUEST/RESPONSE TYPES

src/adcp/types/tasks.py

@@ -15,8 +15,20 @@
 
 from pydantic import BaseModel, Field
 
-# Import core types from adcp.types.core
-# (Product, MediaBuy, CreativeAsset, etc.)
+# Import all types from generated module
+from adcp.types.generated import (
+    BrandManifestRef,
+    Channels,
+    CreativeAsset,
+    CreativeManifest,
+    Error,
+    Format,
+    FormatId,
+    PackageRequest,
+    Product,
+    PushNotificationConfig,
+    StartTiming,
+)
 
 
 class ActivateSignalRequest(BaseModel):