fix(schemas): correct generator annotation in test, add clarifying comments

- Fix _bad_as_file return type to Iterator[Path] (mypy rejects -> None on
  a generator under @contextmanager)
- Move test imports to module level per project convention
- Add comment on intentional over-conservative '..' path-traversal guard
- Add noqa comment on broad except in dynamic schema listing

https://claude.ai/code/session_01TfYXsZysMjHdZBpJqkVW7P

Author: claude

src/adcp/schemas/__init__.py

@@ -44,6 +44,9 @@ def load_schema(name: str) -> dict[str, Any]:
         ``jsonschema`` is a required dependency of ``adcp``.
     """
     # Guard against path traversal: reject names that could escape the package.
+    # Intentionally conservative — any name containing ".." is rejected even if
+    # it wouldn't actually traverse (e.g. "..future.json"); prefer a clear
+    # "invalid" error over a subtle escape.
     if "/" in name or "\\" in name or ".." in name:
         raise FileNotFoundError(
             f"AdCP schema name {name!r} is invalid. "
@@ -67,7 +70,7 @@ def load_schema(name: str) -> dict[str, Any]:
         available = ", ".join(
             sorted(f.name for f in files("adcp.schemas").iterdir() if f.name.endswith(".json"))
         )
-    except Exception:
+    except Exception:  # noqa: BLE001 — intentional: don't mask the real FileNotFoundError
         available = ADCP_AGENTS
 
     raise FileNotFoundError(

tests/test_schemas_module.py

@@ -2,6 +2,11 @@
 
 from __future__ import annotations
 
+from collections.abc import Iterator
+from contextlib import contextmanager
+from pathlib import Path
+from unittest.mock import patch
+
 import pytest
 
 from adcp.schemas import ADCP_AGENTS, load_schema
@@ -45,13 +50,11 @@ def test_load_schema_rejects_path_traversal(traversal: str) -> None:
         load_schema(traversal)
 
 
-def test_load_schema_corrupted_schema_raises_file_not_found(tmp_path) -> None:
+def test_load_schema_corrupted_schema_raises_file_not_found(tmp_path: Path) -> None:
     """A corrupted bundled file should surface as FileNotFoundError, not JSONDecodeError."""
-    from contextlib import contextmanager
-    from unittest.mock import patch
 
-    @contextmanager  # type: ignore[misc]
-    def _bad_as_file(resource) -> None:  # type: ignore[misc]
+    @contextmanager
+    def _bad_as_file(resource: object) -> Iterator[Path]:
         bad = tmp_path / "bad.json"
         bad.write_text("not json", encoding="utf-8")
         yield bad