test: align media-buy fixtures with beta 7 schema

bokelley · bokelley · commit 32a0307ced7c · 2026-05-28T07:37:29.000-04:00
diff --git a/examples/minimal_sales_agent.py b/examples/minimal_sales_agent.py
@@ -280,6 +280,8 @@ async def create_media_buy(
     return CreateMediaBuySuccessResponse(
         media_buy_id=media_buy_id,
         buyer_ref=buyer_ref,
+        confirmed_at="2026-05-01T00:00:00Z",
+        revision=1,
         packages=confirmed_packages,
     ).model_dump(mode="json", exclude_none=True)
 
diff --git a/examples/type_aliases_demo.py b/examples/type_aliases_demo.py
@@ -42,6 +42,8 @@ def handle_create_media_buy_response(
     success = CreateMediaBuySuccessResponse(
         media_buy_id="mb_12345",
         buyer_ref="ref_67890",
+        confirmed_at="2026-05-01T00:00:00Z",
+        revision=1,
         packages=[],
     )
     handle_create_media_buy_response(success)
diff --git a/tests/integration/test_a2a_context_id.py b/tests/integration/test_a2a_context_id.py
@@ -70,7 +70,12 @@ async def get_products(self, params: Any, context: Any = None) -> dict[str, Any]
         return {"products": []}
 
     async def create_media_buy(self, params: Any, context: Any = None) -> dict[str, Any]:
-        return {"media_buy_id": "mb-1", "packages": []}
+        return {
+            "media_buy_id": "mb-1",
+            "confirmed_at": "2026-05-01T00:00:00Z",
+            "revision": 1,
+            "packages": [],
+        }
 
 
 def _part_data_dict(part: pb.Part) -> dict[str, Any] | None:
@@ -276,6 +281,8 @@ async def execute(self, context: RequestContext, event_queue: EventQueue) -> Non
         if state == pb.TaskState.TASK_STATE_COMPLETED:
             data: dict[str, Any] = {
                 "media_buy_id": "mb-1",
+                "confirmed_at": "2026-05-01T00:00:00Z",
+                "revision": 1,
                 "packages": [],
                 "approved": True,
             }
diff --git a/tests/test_client.py b/tests/test_client.py
@@ -1051,6 +1051,8 @@ async def test_get_media_buys_parses_response():
             {
                 "media_buy_id": "mb-1",
                 "status": "active",
+                "confirmed_at": "2026-05-01T00:00:00Z",
+                "revision": 1,
                 "currency": "USD",
                 "total_budget": 5000.0,
                 "packages": [
@@ -1115,6 +1117,8 @@ async def test_get_media_buys_parses_snapshot_response():
             {
                 "media_buy_id": "mb-2",
                 "status": "active",
+                "confirmed_at": "2026-05-01T00:00:00Z",
+                "revision": 1,
                 "currency": "USD",
                 "total_budget": 10000.0,
                 "packages": [
diff --git a/tests/test_decisioning_handler.py b/tests/test_decisioning_handler.py
@@ -189,6 +189,8 @@ class _Platform(DecisioningPlatform):
         async def create_media_buy(self, req, ctx):
             return CreateMediaBuySuccessResponse(
                 media_buy_id="mb_xyz",
+                confirmed_at="2026-05-01T00:00:00Z",
+                revision=1,
                 packages=[],
                 status="active",
             )
@@ -268,6 +270,7 @@ async def update_media_buy(self, media_buy_id, patch, ctx):
             seen_args["patch_paused"] = patch.paused
             return UpdateMediaBuySuccessResponse(
                 media_buy_id=media_buy_id,
+                revision=2,
                 status="paused",
                 packages=[],
             )
diff --git a/tests/test_decisioning_webhook_emit.py b/tests/test_decisioning_webhook_emit.py
@@ -412,10 +412,16 @@ def get_products(self, req, ctx):
         return {"products": []}
 
     def create_media_buy(self, req, ctx):
-        return CreateMediaBuySuccessResponse(media_buy_id="mb_1", packages=[], status="active")
+        return CreateMediaBuySuccessResponse(
+            media_buy_id="mb_1",
+            confirmed_at="2026-05-01T00:00:00Z",
+            revision=1,
+            packages=[],
+            status="active",
+        )
 
     def update_media_buy(self, media_buy_id, patch, ctx):
-        return {"media_buy_id": media_buy_id, "status": "active"}
+        return {"media_buy_id": media_buy_id, "revision": 2, "status": "active"}
 
     def sync_creatives(self, req, ctx):
         return {"creatives": []}
@@ -434,13 +440,17 @@ def get_products(self, req, ctx):
     def create_media_buy(self, req, ctx):
         async def _review(task_ctx):
             return CreateMediaBuySuccessResponse(
-                media_buy_id="mb_after_review", packages=[], status="active"
+                media_buy_id="mb_after_review",
+                confirmed_at="2026-05-01T00:00:00Z",
+                revision=1,
+                packages=[],
+                status="active",
             )
 
         return ctx.handoff_to_task(_review)
 
     def update_media_buy(self, media_buy_id, patch, ctx):
-        return {"media_buy_id": media_buy_id, "status": "active"}
+        return {"media_buy_id": media_buy_id, "revision": 2, "status": "active"}
 
     def sync_creatives(self, req, ctx):
         return {"creatives": []}
diff --git a/tests/test_idempotency.py b/tests/test_idempotency.py
@@ -23,6 +23,16 @@
 UUID_RE = re.compile(r"^[0-9a-f]{8}-[0-9a-f]{4}-4[0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$")
 
 
+def _media_buy_data(media_buy_id: str, **extra: Any) -> dict[str, Any]:
+    return {
+        "media_buy_id": media_buy_id,
+        "confirmed_at": "2026-05-01T00:00:00Z",
+        "revision": 1,
+        "packages": [],
+        **extra,
+    }
+
+
 class TestKeyHelpers:
     def test_generate_key_returns_uuid_v4(self) -> None:
         key = _idempotency.generate_key()
@@ -550,17 +560,7 @@ async def test_replayed_surfaces_on_result(self) -> None:
             artifacts=[
                 Artifact(
                     artifact_id="a1",
-                    parts=[
-                        Part(
-                            root=DataPart(
-                                data={
-                                    "replayed": True,
-                                    "media_buy_id": "mb_1",
-                                    "packages": [],
-                                }
-                            )
-                        )
-                    ],
+                    parts=[Part(root=DataPart(data=_media_buy_data("mb_1", replayed=True)))],
                 )
             ],
         )
@@ -585,7 +585,7 @@ async def test_injects_key_into_mcp_call(self) -> None:
         mock_result = MagicMock()
         mock_result.isError = False
         mock_result.content = []
-        mock_result.structuredContent = {"media_buy_id": "mb_1"}
+        mock_result.structuredContent = _media_buy_data("mb_1")
         session.call_tool = AsyncMock(return_value=mock_result)
         with patch.object(adapter, "_get_session", AsyncMock(return_value=session)):
             await adapter._call_mcp_tool("create_media_buy", {"brand": "acme"})
@@ -676,11 +676,7 @@ async def test_replayed_surfaces_via_mcp(self) -> None:
         mock_result = MagicMock()
         mock_result.isError = False
         mock_result.content = []
-        mock_result.structuredContent = {
-            "replayed": True,
-            "media_buy_id": "mb_1",
-            "packages": [],
-        }
+        mock_result.structuredContent = _media_buy_data("mb_1", replayed=True)
         session.call_tool = AsyncMock(return_value=mock_result)
         with patch.object(adapter, "_get_session", AsyncMock(return_value=session)):
             result = await adapter._call_mcp_tool("create_media_buy", {"brand": "acme"})
@@ -851,7 +847,7 @@ async def fake_send(request: Any) -> Any:  # noqa: D401
                 artifacts=[
                     Artifact(
                         artifact_id="a1",
-                        parts=[DataPart(data={"media_buy_id": "mb_1"})],
+                        parts=[DataPart(data=_media_buy_data("mb_1"))],
                     )
                 ],
             )
diff --git a/tests/test_idempotency_storyboard.py b/tests/test_idempotency_storyboard.py
@@ -48,6 +48,16 @@ def _task_with_data(data: dict[str, Any]) -> Task:
     )
 
 
+def _media_buy_data(media_buy_id: str, **extra: Any) -> dict[str, Any]:
+    return {
+        "media_buy_id": media_buy_id,
+        "confirmed_at": "2026-05-01T00:00:00Z",
+        "revision": 1,
+        "packages": [],
+        **extra,
+    }
+
+
 def _cfg() -> AgentConfig:
     return AgentConfig(
         id="storyboard_seller",
@@ -136,11 +146,7 @@ async def mock_send(request: Any) -> SendMessageSuccessResponse:
                 data = dict(seller_cache[key])
                 data["replayed"] = True
                 return SendMessageSuccessResponse(result=_task_with_data(data))
-            fresh = {
-                "media_buy_id": f"mb_{uuid.uuid4().hex[:8]}",
-                "idempotency_key": key,
-                "packages": [],
-            }
+            fresh = _media_buy_data(f"mb_{uuid.uuid4().hex[:8]}", idempotency_key=key)
             seller_cache[key] = fresh
             return SendMessageSuccessResponse(result=_task_with_data(fresh))
 
@@ -212,11 +218,7 @@ async def mock_send(request: Any) -> SendMessageSuccessResponse:
                 data = dict(seller_cache[key])
                 data["replayed"] = True
                 return SendMessageSuccessResponse(result=_task_with_data(data))
-            fresh = {
-                "media_buy_id": f"mb_{uuid.uuid4().hex[:8]}",
-                "idempotency_key": key,
-                "packages": [],
-            }
+            fresh = _media_buy_data(f"mb_{uuid.uuid4().hex[:8]}", idempotency_key=key)
             seller_cache[key] = fresh
             return SendMessageSuccessResponse(result=_task_with_data(fresh))
 
@@ -253,7 +255,7 @@ async def mock_send(request: Any) -> SendMessageSuccessResponse:
                 return SendMessageSuccessResponse(result=_task_with_data(data))
             mb_id = f"mb_{uuid.uuid4().hex[:8]}"
             created_ids.add(mb_id)
-            fresh = {"media_buy_id": mb_id, "idempotency_key": key, "packages": []}
+            fresh = _media_buy_data(mb_id, idempotency_key=key)
             seller_cache[key] = fresh
             return SendMessageSuccessResponse(result=_task_with_data(fresh))
 
diff --git a/tests/test_implementation_config.py b/tests/test_implementation_config.py
@@ -13,7 +13,6 @@
 
 from concurrent.futures import ThreadPoolExecutor
 from typing import Any
-from unittest.mock import AsyncMock, MagicMock
 
 import pytest
 
@@ -22,14 +21,12 @@
     DecisioningCapabilities,
     DecisioningPlatform,
     InMemoryTaskRegistry,
-    ProductConfigStore,
     SingletonAccounts,
 )
 from adcp.decisioning.handler import PlatformHandler
 from adcp.decisioning.implementation_config import ProductConfigStore as _ProductConfigStoreProto
 from adcp.server.base import ToolContext
 
-
 # ---------------------------------------------------------------------------
 # Fixtures
 # ---------------------------------------------------------------------------
@@ -80,6 +77,17 @@ def _make_handler(
     )
 
 
+def _create_success(media_buy_id: str):
+    from adcp.types import CreateMediaBuySuccessResponse
+
+    return CreateMediaBuySuccessResponse(
+        media_buy_id=media_buy_id,
+        confirmed_at="2026-05-01T00:00:00Z",
+        revision=1,
+        packages=[],
+    )
+
+
 # ---------------------------------------------------------------------------
 # Tests
 # ---------------------------------------------------------------------------
@@ -100,9 +108,8 @@ class _Platform(DecisioningPlatform):
 
         async def create_media_buy(self, req, ctx, configs=None):
             received_configs.append(configs or {})
-            from adcp.types import CreateMediaBuySuccessResponse
 
-            return CreateMediaBuySuccessResponse(media_buy_id="mb_001", packages=[])
+            return _create_success("mb_001")
 
     handler = _make_handler(_Platform(), executor, config_store=_Store())
     req = _make_request(["pid1", "pid2", "pid3"])
@@ -132,9 +139,8 @@ class _Platform(DecisioningPlatform):
 
         async def create_media_buy(self, req, ctx, configs=None):
             received_configs.append(configs or {})
-            from adcp.types import CreateMediaBuySuccessResponse
 
-            return CreateMediaBuySuccessResponse(media_buy_id="mb_002", packages=[])
+            return _create_success("mb_002")
 
     handler = _make_handler(_Platform(), executor, config_store=_Store())
     req = _make_request(["pid1", "pid2", "pid3"])
@@ -156,9 +162,7 @@ class _Platform(DecisioningPlatform):
         accounts = SingletonAccounts(account_id="seller")
 
         async def create_media_buy(self, req, ctx, configs=None):
-            from adcp.types import CreateMediaBuySuccessResponse
-
-            return CreateMediaBuySuccessResponse(media_buy_id="mb_003", packages=[])
+            return _create_success("mb_003")
 
     handler = _make_handler(_Platform(), executor, config_store=_Store())
     req = _make_request(["pid1"])
@@ -183,9 +187,7 @@ class _Platform(DecisioningPlatform):
         accounts = SingletonAccounts(account_id="seller")
 
         async def create_media_buy(self, req, ctx, configs=None):
-            from adcp.types import CreateMediaBuySuccessResponse
-
-            return CreateMediaBuySuccessResponse(media_buy_id="mb_004", packages=[])
+            return _create_success("mb_004")
 
     handler = _make_handler(_Platform(), executor, config_store=_Store())
     req = _make_request(["pid1"])
@@ -213,9 +215,8 @@ class _Platform(DecisioningPlatform):
 
         async def create_media_buy(self, req, ctx, configs=None):
             received_configs.append(configs or {})
-            from adcp.types import CreateMediaBuySuccessResponse
 
-            return CreateMediaBuySuccessResponse(media_buy_id="mb_005", packages=[])
+            return _create_success("mb_005")
 
     handler = _make_handler(_Platform(), executor, config_store=_Store())
     req = _make_request(None)  # proposal_id flow, packages=None
@@ -236,9 +237,8 @@ class _Platform(DecisioningPlatform):
 
         async def create_media_buy(self, req, ctx, configs=None):
             received_configs.append(configs or {})
-            from adcp.types import CreateMediaBuySuccessResponse
 
-            return CreateMediaBuySuccessResponse(media_buy_id="mb_006", packages=[])
+            return _create_success("mb_006")
 
     import warnings
 
@@ -271,9 +271,8 @@ class _Platform(DecisioningPlatform):
 
         async def create_media_buy(self, req, ctx):  # no configs kwarg
             received_req_ids.append(req.idempotency_key)
-            from adcp.types import CreateMediaBuySuccessResponse
 
-            return CreateMediaBuySuccessResponse(media_buy_id="mb_007", packages=[])
+            return _create_success("mb_007")
 
     handler = _make_handler(_Platform(), executor, config_store=_Store())
     req = _make_request(["pid1"])
@@ -287,9 +286,9 @@ async def create_media_buy(self, req, ctx):  # no configs kwarg
 
 def test_product_config_store_protocol_exported() -> None:
     """ProductConfigStore is importable from adcp.decisioning."""
-    from adcp.decisioning import ProductConfigStore as PCS
+    from adcp.decisioning import ProductConfigStore as ProductConfigStoreExport
 
-    assert PCS is _ProductConfigStoreProto
+    assert ProductConfigStoreExport is _ProductConfigStoreProto
 
 
 def test_no_store_with_configs_kwarg_emits_warning(executor) -> None:
@@ -301,9 +300,7 @@ class _Platform(DecisioningPlatform):
         accounts = SingletonAccounts(account_id="seller")
 
         async def create_media_buy(self, req, ctx, configs=None):
-            from adcp.types import CreateMediaBuySuccessResponse
-
-            return CreateMediaBuySuccessResponse(media_buy_id="mb_008", packages=[])
+            return _create_success("mb_008")
 
     with warnings.catch_warnings(record=True) as caught:
         warnings.simplefilter("always")
diff --git a/tests/test_media_buy_store_integration.py b/tests/test_media_buy_store_integration.py

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,8 @@ def handle_create_media_buy_response(`
`42`	`42`	`success = CreateMediaBuySuccessResponse(`
`43`	`43`	`media_buy_id="mb_12345",`
`44`	`44`	`buyer_ref="ref_67890",`
	`45`	`+ confirmed_at="2026-05-01T00:00:00Z",`
	`46`	`+ revision=1,`
`45`	`47`	`packages=[],`
`46`	`48`	`)`
`47`	`49`	`handle_create_media_buy_response(success)`