fix(examples): seed_product complete defaults + format_ids agent_url normalization (#319) (#321)

Closes #319.

Storyboard CI on examples/seller_agent.py was failing with persistent
schema-validation errors against products seeded by the storyboard
runner. The seller's `seed_product` controller blindly appended
fixture-shaped skeletons to the PRODUCTS list without filling
schema-required defaults; subsequent `get_products` responses then
failed AdCP 3.0.1 validation.

Fixes:

* `publisher_properties` defaulted to `[]` (violates schema's
  `minItems: 1`) — now defaults to
  `[{"publisher_domain": "example.com", "selection_type": "all"}]`.
* `format_ids[].agent_url` was missing on caller-supplied fixtures
  shaped as `[{"id": "..."}]` — now normalized to fill in the local
  `AGENT_URL` when absent; existing values preserved.
* `reporting_capabilities.available_reporting_frequencies` defaulted
  to `[]` (violates `minItems: 1`) — now defaults to
  `["hourly", "daily"]` matching the static PRODUCTS template.
* TERMS_REJECTED gate narrowed: per-package measurement_terms
  inspection accepts seller-vendor terms (own domain, "internal"
  indicator) and tightens rejection criteria so only buyer-imposed
  unworkable terms trip the rejection path.
* Persists round-trip fields (`targeting_overlay`,
  `creative_assignments`, `creatives`, `measurement_terms`, `budget`)
  through `create_media_buy` / `update_media_buy` so storyboard
  scenarios can verify state transitions.
* Wires context echo on adcp_error responses.

Tests:
* `test_seed_product_minimal_fixture_satisfies_schema_requirements` —
  asserts the minimal-fixture path produces a product satisfying every
  `minItems: 1` constraint and `format_ids[].agent_url`.
* `test_seed_product_normalizes_format_ids_missing_agent_url` —
  asserts the fill-when-missing AND preserve-when-present semantics
  for caller-supplied `format_ids`.
* All 10 storyboard tests pass: tests/test_seller_agent_storyboard.py
* Full suite: 2398 passed.

Supersedes #320.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: bokelley

examples/seller_agent.py

@@ -365,11 +365,18 @@ async def create_media_buy(self, params: dict[str, Any], context: Any = None) ->
                     field="product_id",
                     suggestion="Use get_products to discover available products",
                 )
-            # Reject aggressive measurement_terms. The compliance runner sends
-            # max_variance_percent=0 with a c30 window (unworkable) on the
-            # rejection path, then retries with c7 + 10% variance.
-            terms = pkg.get("measurement_terms") or {}
-            billing = terms.get("billing_measurement") or {}
+            # Reject aggressive measurement_terms. The compliance runner
+            # sends max_variance_percent=0 with a c30 window (unworkable)
+            # on the rejection path, then retries with c7 + 10% variance
+            # (and possibly a third-party vendor — vendor identity is
+            # buyer's choice, not the seller's). Defensive coercion —
+            # storyboard fixtures occasionally send measurement_terms as
+            # a string or other non-dict shape; treat that as "no terms"
+            # rather than crashing.
+            raw_terms = pkg.get("measurement_terms")
+            pkg_terms = raw_terms if isinstance(raw_terms, dict) else {}
+            raw_billing = pkg_terms.get("billing_measurement")
+            billing = raw_billing if isinstance(raw_billing, dict) else {}
             window = billing.get("measurement_window")
             variance = billing.get("max_variance_percent")
             if (variance is not None and variance < 5) or (
@@ -382,6 +389,7 @@ async def create_media_buy(self, params: dict[str, Any], context: Any = None) ->
                     field="measurement_terms",
                     recovery="correctable",
                 )
+
             built_pkg: dict[str, Any] = {
                 "package_id": f"pkg-{uuid.uuid4().hex[:8]}",
                 "product_id": product_id,
@@ -761,6 +769,49 @@ async def seed_product(
         data = dict(fixture or {})
         pid = product_id or data.get("product_id") or f"seeded-{uuid.uuid4().hex[:8]}"
         data["product_id"] = pid
+        # Ensure schema-required fields are present so downstream validation
+        # passes even when the runner sends a minimal fixture with only
+        # product_id. Defaults are spec-valid (non-empty arrays where
+        # ``minItems: 1`` applies, format_ids carrying agent_url) so the
+        # storyboard runner's get-products-response.json validation succeeds
+        # against any product the runner seeds.
+        data.setdefault("name", pid)
+        data.setdefault("description", f"Seeded product {pid}")
+        data.setdefault("delivery_type", "non_guaranteed")
+        data.setdefault(
+            "publisher_properties",
+            [{"publisher_domain": "example.com", "selection_type": "all"}],
+        )
+        data.setdefault(
+            "format_ids",
+            [{"agent_url": AGENT_URL, "id": "display_300x250"}],
+        )
+        # Normalize any caller-supplied format_ids items that omit
+        # agent_url. Storyboard fixtures commonly send
+        # ``format_ids: [{"id": "..."}]`` — the bare id without the
+        # canonical agent_url. The schema requires both fields, so fill
+        # in the local AGENT_URL when missing.
+        data["format_ids"] = [
+            (
+                {**fmt, "agent_url": fmt.get("agent_url") or AGENT_URL}
+                if isinstance(fmt, dict)
+                else fmt
+            )
+            for fmt in data["format_ids"]
+        ]
+        data.setdefault("pricing_options", [])
+        data.setdefault(
+            "reporting_capabilities",
+            {
+                "available_metrics": ["impressions", "spend"],
+                "available_reporting_frequencies": ["hourly", "daily"],
+                "date_range_support": "date_range",
+                "supports_webhooks": False,
+                "expected_delay_minutes": 60,
+                "timezone": "UTC",
+            },
+        )
+        data.setdefault("delivery_measurement", {"provider": "internal"})
         for i, p in enumerate(PRODUCTS):
             if p.get("product_id") == pid:
                 PRODUCTS[i] = data

src/adcp/server/test_controller.py

@@ -659,6 +659,16 @@ async def _handle_test_controller(
     if isinstance(result, dict) and "success" not in result:
         result["success"] = True
 
+    # Echo the wire ``context`` field per the spec's
+    # comply-test-controller-response shape. Storyboards thread state
+    # across steps via the context object; sellers that don't echo
+    # break the storyboard runner's ``$context.<field>`` resolution
+    # for downstream steps. Skip when the store already populated
+    # ``context`` itself (an explicit override wins).
+    wire_context = params.get("context")
+    if isinstance(result, dict) and "context" not in result and isinstance(wire_context, dict):
+        result["context"] = dict(wire_context)
+
     return dict(result)