Skip to content

Commit 014f729

Browse files
author
Mark Adamcin
committed
found a few issues with running maven under jdk 6. Decided to bump the source and target java versions to 1.6, normalize the servlet-api dependency to 2.4, and remove references to a Java 1.7 RT class (java.util.Objects)
1 parent b2b34a0 commit 014f729

File tree

3 files changed

+17
-9
lines changed

3 files changed

+17
-9
lines changed

hmac/src/main/java/net/adamcin/httpsig/hmac/HmacKey.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import java.security.NoSuchAlgorithmException;
3939
import java.util.Arrays;
4040
import java.util.HashSet;
41-
import java.util.Objects;
4241
import java.util.Set;
4342

4443
public class HmacKey implements Key {
@@ -55,8 +54,14 @@ public class HmacKey implements Key {
5554
* @param secret The secret used to sign
5655
*/
5756
public HmacKey(String keyId, String secret) {
58-
this.keyId = Objects.requireNonNull(keyId, "keyId must not be null");
59-
this.secret = Objects.requireNonNull(secret, "secret must not be null");
57+
if (keyId == null) {
58+
throw new NullPointerException("keyId must not be null");
59+
}
60+
if (secret == null) {
61+
throw new NullPointerException("secret must not be null");
62+
}
63+
this.keyId = keyId;
64+
this.secret = secret;
6065
}
6166

6267
/**

http-helpers/src/test/java/net/adamcin/httpsig/http/HttpServerTestBody.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import net.adamcin.httpsig.ssh.jce.AuthorizedKeys;
4040
import net.adamcin.httpsig.testutil.KeyTestUtil;
4141
import org.eclipse.jetty.server.Server;
42-
import org.eclipse.jetty.server.ServerConnector;
4342
import org.eclipse.jetty.servlet.ServletHandler;
4443
import org.eclipse.jetty.servlet.ServletHolder;
4544
import org.slf4j.Logger;
@@ -82,7 +81,7 @@ protected void setServlet(Servlet servlet) throws Exception {
8281

8382
protected Integer getPort() {
8483
if (server.getConnectors().length > 0) {
85-
return ((ServerConnector) server.getConnectors()[0]).getLocalPort();
84+
return server.getConnectors()[0].getLocalPort();
8685
} else {
8786
return null;
8887
}

pom.xml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,16 +65,16 @@
6565

6666
<properties>
6767
<encoding>UTF-8</encoding>
68-
<package-info.version>1.1.0</package-info.version>
69-
<maven.compiler.source>1.5</maven.compiler.source>
70-
<maven.compiler.target>1.5</maven.compiler.target>
68+
<package-info.version>1.2.0</package-info.version>
69+
<maven.compiler.source>1.6</maven.compiler.source>
70+
<maven.compiler.target>1.6</maven.compiler.target>
7171
<slf4j.version>1.6.1</slf4j.version>
7272
<junit.version>4.11</junit.version>
7373
<maven.bundle.plugin.version>2.3.7</maven.bundle.plugin.version>
7474
<maven.scr.plugin.version>1.9.0</maven.scr.plugin.version>
7575
<scr.annotations.version>1.7.0</scr.annotations.version>
7676
<scr.generator.version>1.3.0</scr.generator.version>
77-
<jetty.version>9.1.0.v20131115</jetty.version>
77+
<jetty.version>7.6.16.v20140903</jetty.version>
7878
</properties>
7979

8080
<issueManagement>
@@ -108,6 +108,10 @@
108108
<build>
109109
<pluginManagement>
110110
<plugins>
111+
<plugin>
112+
<artifactId>maven-enforcer-plugin</artifactId>
113+
<version>1.3.1</version>
114+
</plugin>
111115
<plugin>
112116
<artifactId>maven-clean-plugin</artifactId>
113117
<version>2.4.1</version>

0 commit comments

Comments
 (0)