Skip to content

Commit 196128e

Browse files
committed
fix(ci): Kai follow-up — 80-col .ci.sh, revert jslint coverage spawn
- Wrap libomp comment and error printf in .ci.sh to 80 columns - Restore jslint.mjs and jslint_ci.sh to beta (exit handler, not close) Made-with: Cursor
1 parent 1dfe8e1 commit 196128e

3 files changed

Lines changed: 10 additions & 25 deletions

File tree

.ci.sh

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,17 @@ process.stdout.write(
4949
case "$(uname)" in
5050
Darwin*)
5151
brew install libomp
52-
# Use the keg path for *this* brew (ARM → /opt/homebrew, Intel → /usr/local).
53-
# Hard-coding /opt/homebrew first breaks macos-15-intel (GitHub-hosted) runners.
52+
# Use the keg path for *this* brew (ARM → /opt/homebrew,
53+
# Intel → /usr/local).
54+
# Hard-coding /opt/homebrew first breaks
55+
# macos-15-intel (GitHub-hosted) runners.
5456
LIBOMP_ROOT="$(brew --prefix libomp)"
5557
if [ ! -f "$LIBOMP_ROOT/lib/libomp.dylib" ]
5658
then
57-
printf "%s\n" "shCiBaseCustom: libomp.dylib not found at $LIBOMP_ROOT/lib/libomp.dylib" 1>&2
59+
printf "%s%s\n" \
60+
"shCiBaseCustom: libomp.dylib not found at " \
61+
"$LIBOMP_ROOT/lib/libomp.dylib" \
62+
1>&2
5863
exit 1
5964
fi
6065
rm -f sqlmath/libomp.dylib

jslint.mjs

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11381,17 +11381,7 @@ function sentinel() {}
1138111381
),
1138211382
stdio: ["ignore", 1, 2]
1138311383
}
11384-
).on("close", function (code, signal) {
11385-
let exitCode0;
11386-
if (typeof code === "number") {
11387-
exitCode0 = code;
11388-
} else if (signal) {
11389-
exitCode0 = 1;
11390-
} else {
11391-
exitCode0 = 0;
11392-
}
11393-
resolve(exitCode0);
11394-
});
11384+
).on("exit", resolve);
1139511385
});
1139611386
consoleError(
1139711387
`v8CoverageReportCreate - program exited with exitCode=${exitCode}`

jslint_ci.sh

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3367,17 +3367,7 @@ function sentinel() {}
33673367
),
33683368
stdio: ["ignore", 1, 2]
33693369
}
3370-
).on("close", function (code, signal) {
3371-
let exitCode0;
3372-
if (typeof code === "number") {
3373-
exitCode0 = code;
3374-
} else if (signal) {
3375-
exitCode0 = 1;
3376-
} else {
3377-
exitCode0 = 0;
3378-
}
3379-
resolve(exitCode0);
3380-
});
3370+
).on("exit", resolve);
33813371
});
33823372
consoleError(
33833373
`v8CoverageReportCreate - program exited with exitCode=${exitCode}`

0 commit comments

Comments
 (0)