Create separate documentation scoring criteria for Japanese#23280
Open
hannaw93 wants to merge 1 commit into
Open
Create separate documentation scoring criteria for Japanese#23280hannaw93 wants to merge 1 commit into
hannaw93 wants to merge 1 commit into
Conversation
Coverage Report for CI Build 57082Coverage remained the same at 53.944%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
After this older PR was merged, the scoring documentation for all assessments that live inside the yoastseo package were placed inside the yoastseo package.
The Japanese scoring criteria was included in the default scoring documentation and on [the Confluence page ](Confluence page. This change removes the Japanese scoring documentation from the Confluence page and adds it instead to the yoastseo package, in separate files for more clarity and a more neat organisation.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
grunt build:imagesand committed the results, if my PR introduces or edits images or SVGs.Innovation
innovationlabel.Fixes #https://github.com/orgs/Yoast/projects/94/views/1?pane=issue&itemId=143440138&issue=Yoast%7CLingo-AI%7C2