Skip to content

chore: upgrade redux from 3.7.2 to 4.2.1 across packages#23261

Open
vraja-pro wants to merge 1 commit into
trunkfrom
fix-redux-console-warnings
Open

chore: upgrade redux from 3.7.2 to 4.2.1 across packages#23261
vraja-pro wants to merge 1 commit into
trunkfrom
fix-redux-console-warnings

Conversation

@vraja-pro
Copy link
Copy Markdown
Contributor

@vraja-pro vraja-pro commented May 12, 2026

Redux 3.x depends on symbol-observable which conflicts with the Redux DevTools browser extension, causing a Symbol.observable mismatch warning on every store instantiation. Redux 4 drops the symbol-observable dependency, resolving the warnings.

Context

Summary

This PR can be summarized in the following changelog entry:

  • Upgrades redux from 3.7.2 to 4.2.1 across packages to remove 10 console warnings.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Add to wp-config.php
define( ‘SCRIPT_DEBUG’, true );
  • Edit a post and check there are no console warnings:
Screenshot 2026-05-12 at 16 25 01

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and committed the results, if my PR introduces or edits images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/1218

@vraja-pro vraja-pro added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 12, 2026
@vraja-pro vraja-pro changed the base branch from feature/misc-performance to trunk May 12, 2026 14:44
@vraja-pro vraja-pro force-pushed the fix-redux-console-warnings branch from e3b3006 to 08acacc Compare May 12, 2026 14:46
Redux 3.x depends on symbol-observable which conflicts with the Redux
DevTools browser extension, causing a Symbol.observable mismatch
warning on every store instantiation. Redux 4 drops the
symbol-observable dependency, resolving the warnings.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vraja-pro vraja-pro force-pushed the fix-redux-console-warnings branch from 08acacc to 591880b Compare May 12, 2026 14:50
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 1

Warning

No base build found for commit b17f347 on trunk.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 34.287%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 16749
Covered Lines: 6124
Line Coverage: 36.56%
Relevant Branches: 10518
Covered Branches: 3225
Branch Coverage: 30.66%
Branches in Coverage %: Yes
Coverage Strength: 9.1 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants