-
Notifications
You must be signed in to change notification settings - Fork 172
Open
Description
SDK you're using (please complete the following information):
- Version 9.3.0-alpha.5
Describe the bug
The exported types from the xero-node sdk are not capitalised yet the responses from the API are.
This mismatch makes it so that the types can't be used to define response payloads without some kind of manual serialisation step involved, or opting to simply not use them at all.
e.g. GET Payments
API returns BankAmount, Amount etc
The SDK type declaration has these as bankAmount, amount
To Reproduce
Steps to reproduce the behavior:
- Go to API Explorer and call any basic GET endpoint (Payments)
- Observe response with capitalised property names
- Find payment.d.ts file in xero-node SDK
- See the same type but with lowercase starting property names
Expected behavior
The types in the SDK should match the API responses.
I have observed this so far with Payments and Budgets, however I imagine this is the same for most/all endpoints.
Metadata
Metadata
Assignees
Labels
No labels

