Minimal xbl#46
Draft
ChristopherHX wants to merge 4 commits into
Draft
Conversation
ChristopherHX
commented
May 18, 2026
| @@ -178,15 +210,15 @@ HRESULT WINAPI QueryApiImpl( const GUID *runtimeClassId, REFIID interfaceId, voi | |||
|
|
|||
| TRACE("runtimeClassId %s, interfaceId %s, out %p\n", debugstr_guid(runtimeClassId), debugstr_guid(interfaceId), out); | |||
|
|
|||
| if ( IsEqualGUID( runtimeClassId, &CLSID_XSystemImpl ) ) | |||
| if ( !func && IsEqualGUID( runtimeClassId, &CLSID_XSystemImpl ) ) | |||
Author
There was a problem hiding this comment.
This implementations is wrong, therefore prefer the microsoft implementation
ChristopherHX
commented
May 18, 2026
| { | ||
| return IXSystemImpl_QueryInterface( x_system_impl, interfaceId, out ); | ||
| } | ||
| else if ( IsEqualGUID( runtimeClassId, &CLSID_XGameRuntimeFeatureImpl ) ) | ||
| { | ||
| return IXGameRuntimeFeatureImpl_QueryInterface( x_game_runtime_feature_impl, interfaceId, out ); | ||
| } | ||
| else if ( IsEqualGUID( runtimeClassId, &CLSID_XSystemAnalyticsImpl ) ) | ||
| else if ( !func && IsEqualGUID( runtimeClassId, &CLSID_XSystemAnalyticsImpl ) ) |
Author
There was a problem hiding this comment.
the replacement might work correctly, not tested
ChristopherHX
commented
May 18, 2026
| @@ -131,6 +161,8 @@ HRESULT WINAPI InitializeApiImplEx2( ULONG gdkVer, ULONG gsVer, CHAR mode, INITI | |||
| // There's no documented information about what `INITIALIZE_OPTIONS` is, | |||
| // and xgameruntime.lib never utilizes this argument anyway. | |||
| TRACE("gdkVer %ld, gsVer %ld, mode %d, options %p stub!\n", gdkVer, gsVer, mode, options); | |||
| static INIT_ONCE once = INIT_ONCE_STATIC_INIT; | |||
| InitOnceExecuteOnce(&once, &SetUpXgameruntimeCrossPlatformMode, NULL, NULL); | |||
Author
There was a problem hiding this comment.
Ensure to only call SetUpXgameruntimeCrossPlatformMode once, so the callbacks are not added multiple times and to avoid side effects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Fallback to XUserless winegdk missingDoneIf you replace
MicrosoftGame.Configwith this content login to Minecraft works.I could also auto replace that in xgameruntime.dll here, e.g. pass the config as static string to the real xgameruntime.dll.
Idl of IXuser copyright @olivi-r .
This is clean room code and does not integrate any xbox live logic into winegdk that have to be reverse engineered.
The original
MicrosoftGame.Configblocks sign in via the login flow the cross platform implementation uses