eventbus: move event bus triggers to vpe project. Add GetLampValue

Author: jsm174

Editor/Widgets/GetLampValueUnitWidget.cs

@@ -0,0 +1,56 @@
+using System;
+using System.Collections.Generic;
+using Unity.VisualScripting;
+using VisualPinball.Unity;
+
+namespace VisualPinball.Unity.VisualScripting
+{
+    [Widget(typeof(GetLampValueUnit))]
+    public sealed class GetLampValueUnitWidget : UnitWidget<GetLampValueUnit>
+    {
+        public GetLampValueUnitWidget(FlowCanvas canvas, GetLampValueUnit unit) : base(canvas, unit)
+        {
+            lampIdInspectorConstructor = (metadata) => new VariableNameInspector(metadata, GetNameSuggestions);
+        }
+
+        protected override NodeColorMix baseColor => NodeColorMix.TealReadable;
+
+        private VariableNameInspector lampIdInspector;
+        private Func<Metadata, VariableNameInspector> lampIdInspectorConstructor;
+
+        public override Inspector GetPortInspector(IUnitPort port, Metadata metadata)
+        {
+            if (port == unit.id)
+            {
+                // This feels so hacky. The real holy grail here would be to support attribute decorators like Unity does.
+                InspectorProvider.instance.Renew(ref lampIdInspector, metadata, lampIdInspectorConstructor);
+
+                return lampIdInspector;
+            }
+
+            return base.GetPortInspector(port, metadata);
+        }
+
+        private IEnumerable<string> GetNameSuggestions()
+        {
+            List<string> list = new List<string>();
+
+            var tableComponent = TableSelector.Instance.SelectedTable;
+
+            if (tableComponent != null)
+            {
+                var gle = tableComponent.gameObject.GetComponent<IGamelogicEngine>();
+
+                if (gle != null)
+                {
+                    foreach (var lamp in gle.AvailableLamps)
+                    {
+                        list.Add(lamp.Id);
+                    }
+                }
+            }
+
+            return list;
+        }
+    }
+}

Runtime/ScriptingEngine.cs.meta …r/Widgets/GetLampValueUnitWidget.cs.metaRuntime/ScriptingEngine.cs.meta renamed to Editor/Widgets/GetLampValueUnitWidget.cs.meta Runtime/ScriptingEngine.cs.meta renamed to Editor/Widgets/GetLampValueUnitWidget.cs.meta

@@ -2,11 +2,6 @@
 
 namespace VisualPinball.Unity.VisualScripting
 {
-    public static class EventNames
-    {
-        public static string LampEvent = "LampEvent";
-    }
-
     [UnitTitle("On Lamp Event")]
     [UnitCategory("Events\\Visual Pinball")]
     public sealed class LampEventUnit : EventUnit<LampEventArgs>

Runtime/Events/Nodes/LampEventUnit.cs

@@ -0,0 +1,51 @@
+using Unity.VisualScripting;
+
+namespace VisualPinball.Unity.VisualScripting
+{
+    [UnitTitle("Get Lamp Value")]
+    [UnitCategory("Visual Pinball")]
+    public class GetLampValueUnit : Unit
+    {
+        [DoNotSerialize]
+        [PortLabelHidden]
+        public ValueInput id { get; private set; }
+
+        [DoNotSerialize]
+        [PortLabelHidden]
+        public ValueOutput value { get; private set; }
+
+        [DoNotSerialize]
+        [PortLabelHidden]
+        public ValueOutput enabled { get; private set; }
+
+        private Player _player;
+
+        protected override void Definition()
+        {
+            id = ValueInput(nameof(id), string.Empty);
+
+            value = ValueOutput(nameof(value), GetValue);
+            enabled = ValueOutput(nameof(enabled), GetEnabled);
+        }
+
+        private float GetValue(Flow flow)
+        {
+            if (_player == null) {
+                _player = UnityEngine.Object.FindObjectOfType<Player>();
+            }
+
+            var key = flow.GetValue<string>(id);
+            return _player.LampStatuses.ContainsKey(key) ? _player.LampStatuses[key] : 0;
+        }
+
+        private bool GetEnabled(Flow flow)
+        {
+            if (_player == null) {
+                _player = UnityEngine.Object.FindObjectOfType<Player>();
+            }
+
+            var key = flow.GetValue<string>(id);
+            return _player.LampStatuses.ContainsKey(key) ? (_player.LampStatuses[key] > 0) : false;
+        }
+    }
+}

Runtime/Lamps/Nodes/GetLampValueUnit.cs

@@ -15,36 +15,34 @@ public class LampGroupSequenceUnit : Unit
         public ValueInput lightGroup;
 
         [DoNotSerialize]
+        [PortLabelHidden]
         public ValueInput maxLights;
 
         [DoNotSerialize]
         public ControlOutput outputTrigger;
 
         private TableApi _tableApi;
-        private int _currentIndex;
+        private int _currentIndex = 0;
 
         protected override void Definition()
         {
             inputTrigger = ControlInput("In", (flow) => Process(flow));
 
             lightGroup = ValueInput<LightGroupComponent>(nameof(lightGroup));
-            maxLights = ValueInput<int>(nameof(maxLights));
+            maxLights = ValueInput<int>(nameof(maxLights), 1);
 
             outputTrigger = ControlOutput("");
         }
 
         private ControlOutput Process(Flow flow, bool invert = false)
         {
-            
-            if (_tableApi == null)
-            {
+            if (_tableApi == null) {
                 _tableApi = UnityEngine.Object.FindObjectOfType<Player>().TableApi;
             }
 
             // GetValue throws an exception because they are not basic types
 
-            try
-            {
+            try {
                 EnableLightGroup(flow.GetValue<LightGroupComponent>(lightGroup), flow.GetValue<int>(maxLights));
             }
             catch (Exception) { };
@@ -54,35 +52,14 @@ private ControlOutput Process(Flow flow, bool invert = false)
 
         private void EnableLightGroup(LightGroupComponent lightGroupComponent, int maxLights)
         {
-            int index = 0;
-            int count = 0;
+            var totalLights = lightGroupComponent.Lights.Count();
 
-            bool enabled = false;
-   
-            var lights = lightGroupComponent.Lights.SelectMany(l => l.GetComponentsInChildren<LightComponent>());
-
-            foreach (var light in lights)
-            {
-                if (index == _currentIndex)
-                {
-                    enabled = true;
-                }
-
-                if (enabled && ++count > maxLights)
-                {
-                    enabled = false;
-                }
-
-                var lightState = _tableApi.Light(light);
-                lightState.State = enabled ? 1 : 0;
-
-                index++;
+            for (var index = 0; index < totalLights; index++ ) { 
+                _tableApi.Light(lightGroupComponent.Lights[index].GetComponentInChildren<LightComponent>()).State =
+                    (index >= (_currentIndex * maxLights) && index < ((_currentIndex + 1) * maxLights)) ? 1 : 0;
             }
 
-            _currentIndex += maxLights;
-
-            if (_currentIndex > lights.Count())
-            {
+            if (++_currentIndex >= totalLights / maxLights) {
                 _currentIndex = 0;
             }
         }

Runtime/Lamps/Nodes/GetLampValueUnit.cs.meta

@@ -48,39 +48,32 @@ protected override void Definition()
 
         private ControlOutput Process(Flow flow, bool invert = false)
         {
-            if (_tableApi == null)
-            {
+            if (_tableApi == null) {
                 _tableApi = UnityEngine.Object.FindObjectOfType<Player>().TableApi;
             }
 
             // GetValue throws an exception because they are not basic types
 
-            try
-            {
-                foreach (var lightGroupComponent in flow.GetValue<List<LightGroupComponent>>(offLightGroups))
-                {
+            try {
+                foreach (var lightGroupComponent in flow.GetValue<List<LightGroupComponent>>(offLightGroups)) {
                     EnableLightGroup(lightGroupComponent, invert);
                 }
             }
             catch (Exception) { };
 
-            try
-            {
-                foreach (var lightGroupComponent in flow.GetValue<List<LightGroupComponent>>(onLightGroups))
-                {
+            try {
+                foreach (var lightGroupComponent in flow.GetValue<List<LightGroupComponent>>(onLightGroups)) {
                     EnableLightGroup(lightGroupComponent, !invert);
                 }
             }
             catch (Exception) { };
 
-            try
-            {
+            try {
                 EnableLightGroup(flow.GetValue<LightGroupComponent>(offLightGroup), invert);
             }
             catch (Exception) { };
 
-            try
-            {
+            try {
                 EnableLightGroup(flow.GetValue<LightGroupComponent>(onLightGroup), !invert);
             }
             catch (Exception) { };
@@ -90,10 +83,8 @@ private ControlOutput Process(Flow flow, bool invert = false)
 
         private void EnableLightGroup(LightGroupComponent lightGroupComponent, bool enable)
         {
-            foreach (var light in lightGroupComponent.Lights.SelectMany(l => l.GetComponentsInChildren<LightComponent>()))
-            {
-                var lightState = _tableApi.Light(light);
-                lightState.State = enable ? 1 : 0;
+            foreach (var light in lightGroupComponent.Lights.SelectMany(l => l.GetComponentsInChildren<LightComponent>())) {
+                _tableApi.Light(light).State = enable ? 1 : 0;
             }
         }
     }