process: derive AppID from /proc/$pid/cgroup instead of walking the process tree#2190
Open
oSoMoN wants to merge 1 commit into
Open
process: derive AppID from /proc/$pid/cgroup instead of walking the process tree#2190oSoMoN wants to merge 1 commit into
oSoMoN wants to merge 1 commit into
Conversation
…rocess tree
Replace the old get_appid_from_pid(), which walked up the process tree looking
for a "reaper" process and parsing its command line, with a simpler and more
robust approach that reads /proc/$pid/cgroup and extracts the AppID from the
Steam systemd scope name (app-steam-app${appid}-${reaperpid}.scope).
Move the implementation to Utils/Process, and add unit tests.
|
Also note https://blog.sebastianwick.net/posts/so-peerpidfd-gets-more-useful/ could be interesting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the old get_appid_from_pid(), which walked up the process tree looking for a "reaper" process and parsing its command line, with a simpler and more robust approach that reads /proc/$pid/cgroup and extracts the AppID from the Steam systemd scope name (app-steam-app${appid}-${reaperpid}.scope).
Move the implementation to Utils/Process, and add unit tests.