Use keymap from session unless env set.#2169
Open
ninetailedtori wants to merge 5 commits into
Open
Conversation
Signed-off-by: Toria <ninetailedtori@uwu.gal>
Author
|
Attempt given! Hopefully this is the correct method, canonically? But I do welcome advice @wismill if I've cocked up my somewhat shoddy understanding of libxkbcommon! 🙏🏽 |
wismill
reviewed
May 11, 2026
wismill
left a comment
wismill
left a comment
There was a problem hiding this comment.
I did a quick review. I am not familiar with the code base to contribute further.
misyltoad
reviewed
May 11, 2026
Signed-off-by: Toria <ninetailedtori@uwu.gal>
wismill
suggested changes
May 12, 2026
…hat whole if-chain block so it looks cleaner and is efficient with the new checks. Remove a redundant check too. If only env_variant is set of all env vars, we discard the value and continue in p_keymap attempt. Just small optimizations outside of that! Signed-off-by: Toria <ninetailedtori@uwu.gal>
Signed-off-by: Toria <ninetailedtori@uwu.gal>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #203.
Unfortunately I cannot fetch the rules from the keymap once it's compiled, and since the session's keymap fetched is pre-compiled by the session, it is not something I can fetch. Thus, if an env is set, we will rebuild the entire keymap w.r.t the env vars, or sensible defaults. Do let me know if it IS possible to fix this though!
I welcome testing and reviews on this, mighta cocked something up!! (though I hope not xD)