Fix CI failures in timeout tests

- Remove branching and time.sleep from slow_request mocks, fixing
  coverage gaps (partial branches) and Windows CI timeouts
- Remove test_longer_timeout_succeeds (redundant with test_custom_timeout)
- Assert the timeout value is passed correctly instead of branching
- Remove unused time import and unused *args parameter

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: adamtheturtle

tests/test_query.py

@@ -1,7 +1,6 @@
 """Tests for the ``CloudRecoService`` querying functionality."""
 
 import io
-import time
 import uuid
 from typing import BinaryIO
 from unittest.mock import patch
@@ -156,6 +155,7 @@ def test_timeout_raises_on_slow_response(
         image: io.BytesIO | BinaryIO,
     ) -> None:
         """A short timeout raises an error when the server is slow."""
+        custom_timeout = 0.1
         with MockVWS() as mock:
             database = VuforiaDatabase()
             mock.add_database(database=database)
@@ -166,7 +166,7 @@ def test_timeout_raises_on_slow_response(
             cloud_reco_client = CloudRecoService(
                 client_access_key=database.client_access_key,
                 client_secret_key=database.client_secret_key,
-                request_timeout_seconds=0.1,
+                request_timeout_seconds=custom_timeout,
             )
 
             target_id = vws_client.add_target(
@@ -178,19 +178,12 @@ def test_timeout_raises_on_slow_response(
             )
             vws_client.wait_for_target_processed(target_id=target_id)
 
-            simulated_slow_threshold = 0.5
-            original_request = requests.request
-
             def slow_request(
-                *args: object,
                 **kwargs: float | None,
             ) -> requests.Response:
-                """Simulate a slow server response."""
-                timeout = kwargs.get("timeout")
-                if timeout is not None and timeout < simulated_slow_threshold:
-                    time.sleep(0.2)
-                    raise requests.exceptions.Timeout
-                return original_request(*args, **kwargs)  # type: ignore[arg-type]  # pyright: ignore[reportArgumentType]
+                """Simulate a server that is too slow to respond."""
+                assert kwargs["timeout"] == custom_timeout
+                raise requests.exceptions.Timeout
 
             with (
                 patch.object(
@@ -202,55 +195,6 @@ def slow_request(
             ):
                 cloud_reco_client.query(image=image)
 
-    @staticmethod
-    def test_longer_timeout_succeeds(image: io.BytesIO | BinaryIO) -> None:
-        """A longer timeout allows slow responses to complete."""
-        simulated_slow_threshold = 0.5
-
-        with MockVWS() as mock:
-            database = VuforiaDatabase()
-            mock.add_database(database=database)
-            vws_client = VWS(
-                server_access_key=database.server_access_key,
-                server_secret_key=database.server_secret_key,
-            )
-            cloud_reco_client = CloudRecoService(
-                client_access_key=database.client_access_key,
-                client_secret_key=database.client_secret_key,
-                request_timeout_seconds=1.0,
-            )
-
-            target_id = vws_client.add_target(
-                name="x",
-                width=1,
-                image=image,
-                active_flag=True,
-                application_metadata=None,
-            )
-            vws_client.wait_for_target_processed(target_id=target_id)
-
-            original_request = requests.request
-
-            def slow_request(
-                *args: object,
-                **kwargs: float | None,
-            ) -> requests.Response:
-                """Simulate a slow server response."""
-                timeout = kwargs.get("timeout")
-                if timeout is not None and timeout < simulated_slow_threshold:
-                    time.sleep(0.2)
-                    raise requests.exceptions.Timeout
-                return original_request(*args, **kwargs)  # type: ignore[arg-type]  # pyright: ignore[reportArgumentType]
-
-            with patch.object(
-                target=requests,
-                attribute="request",
-                side_effect=slow_request,
-            ):
-                # This should succeed because timeout is 1.0 > 0.5
-                matches = cloud_reco_client.query(image=image)
-                assert len(matches) == 1
-
 
 class TestCustomBaseVWQURL:
     """Tests for using a custom base VWQ URL."""

tests/test_vws.py

@@ -4,7 +4,6 @@
 import datetime
 import io
 import secrets
-import time
 import uuid
 from typing import BinaryIO
 from unittest.mock import patch
@@ -184,29 +183,22 @@ def test_timeout_raises_on_slow_response(
         image: io.BytesIO | BinaryIO,
     ) -> None:
         """A short timeout raises an error when the server is slow."""
-        simulated_slow_threshold = 0.5
-
+        custom_timeout = 0.1
         with MockVWS() as mock:
             database = VuforiaDatabase()
             mock.add_database(database=database)
             vws_client = VWS(
                 server_access_key=database.server_access_key,
                 server_secret_key=database.server_secret_key,
-                request_timeout_seconds=0.1,
+                request_timeout_seconds=custom_timeout,
             )
 
-            original_request = requests.request
-
             def slow_request(
-                *args: object,
                 **kwargs: float | None,
             ) -> requests.Response:
-                """Simulate a slow server response."""
-                timeout = kwargs.get("timeout")
-                if timeout is not None and timeout < simulated_slow_threshold:
-                    time.sleep(0.2)
-                    raise requests.exceptions.Timeout
-                return original_request(*args, **kwargs)  # type: ignore[arg-type]  # pyright: ignore[reportArgumentType]
+                """Simulate a server that is too slow to respond."""
+                assert kwargs["timeout"] == custom_timeout
+                raise requests.exceptions.Timeout
 
             with (
                 patch.object(
@@ -224,47 +216,6 @@ def slow_request(
                     application_metadata=None,
                 )
 
-    @staticmethod
-    def test_longer_timeout_succeeds(image: io.BytesIO | BinaryIO) -> None:
-        """A longer timeout allows slow responses to complete."""
-        simulated_slow_threshold = 0.5
-
-        with MockVWS() as mock:
-            database = VuforiaDatabase()
-            mock.add_database(database=database)
-            vws_client = VWS(
-                server_access_key=database.server_access_key,
-                server_secret_key=database.server_secret_key,
-                request_timeout_seconds=1.0,
-            )
-
-            original_request = requests.request
-
-            def slow_request(
-                *args: object,
-                **kwargs: float | None,
-            ) -> requests.Response:
-                """Simulate a slow server response."""
-                timeout = kwargs.get("timeout")
-                if timeout is not None and timeout < simulated_slow_threshold:
-                    time.sleep(0.2)
-                    raise requests.exceptions.Timeout
-                return original_request(*args, **kwargs)  # type: ignore[arg-type]  # pyright: ignore[reportArgumentType]
-
-            with patch.object(
-                target=requests,
-                attribute="request",
-                side_effect=slow_request,
-            ):
-                # This should succeed because timeout is 1.0 > 0.5
-                vws_client.add_target(
-                    name="x",
-                    width=1,
-                    image=image,
-                    active_flag=True,
-                    application_metadata=None,
-                )
-
 
 class TestCustomBaseVWSURL:
     """Tests for using a custom base VWS URL."""