Skip to content

Commit 5318e39

Browse files
adamtheturtleclaude
andcommitted
Remove default for accept parameter in generate_vumark_instance
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 5b2c7c7 commit 5318e39

File tree

3 files changed

+3
-21
lines changed

3 files changed

+3
-21
lines changed

src/vws/vws.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,7 @@ def generate_vumark_instance(
710710
*,
711711
target_id: str,
712712
instance_id: str,
713-
accept: VuMarkAccept = VuMarkAccept.PNG,
713+
accept: VuMarkAccept,
714714
) -> bytes:
715715
"""Generate a VuMark instance image.
716716

tests/test_vws.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -765,23 +765,3 @@ def test_generate_vumark_instance(
765765
accept=accept,
766766
)
767767
assert result.startswith(expected_prefix)
768-
769-
@staticmethod
770-
def test_generate_vumark_default_accept(
771-
vws_client: VWS,
772-
high_quality_image: io.BytesIO,
773-
) -> None:
774-
"""By default, PNG is returned."""
775-
target_id = vws_client.add_target(
776-
name="x",
777-
width=1,
778-
image=high_quality_image,
779-
active_flag=True,
780-
application_metadata=None,
781-
)
782-
vws_client.wait_for_target_processed(target_id=target_id)
783-
result = vws_client.generate_vumark_instance(
784-
target_id=target_id,
785-
instance_id="12345",
786-
)
787-
assert result.startswith(b"\x89PNG\r\n\x1a\n")

tests/test_vws_exceptions.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
TargetStatusProcessingError,
3737
UnknownTargetError,
3838
)
39+
from vws.vumark_accept import VuMarkAccept
3940

4041

4142
def test_image_too_large(
@@ -384,6 +385,7 @@ def test_invalid_instance_id(
384385
vws_client.generate_vumark_instance(
385386
target_id=target_id,
386387
instance_id="",
388+
accept=VuMarkAccept.PNG,
387389
)
388390

389391
assert exc.value.response.status_code == HTTPStatus.UNPROCESSABLE_ENTITY

0 commit comments

Comments
 (0)