Merge pull request #3181 from VWS-Python/chore/pylint-builtin-bans

Ban dynamic builtins and typing.cast in lint config

Author: adamtheturtle

pyproject.toml

@@ -198,6 +198,7 @@ lint.per-file-ignores."tests/**" = [
 lint.unfixable = [
     "ERA001",
 ]
+lint.flake8-tidy-imports.banned-api."typing.cast".msg = "typing.cast is banned: use explicit type narrowing or a typed variable instead."
 lint.pydocstyle.convention = "google"
 
 [tool.pylint]
@@ -242,6 +243,17 @@ MASTER.per-file-ignores = [
     "docs/source/doccmd_*.py:invalid-name",
     "doccmd_README_rst_*.py:invalid-name",
 ]
+DEPRECATED_BUILTINS.bad-functions = [
+    # Use Pylint until Ruff can ban bare builtin calls, or until custom rules
+    # make this removable:
+    # https://github.com/astral-sh/ruff/issues/10079
+    # https://github.com/astral-sh/ruff/issues/970
+    "filter",
+    "getattr",
+    "hasattr",
+    "map",
+    "setattr",
+]
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option
 # multiple time (only on the command line, not in the configuration file where

src/mock_vws/_requests_mock_server/decorators.py

@@ -160,7 +160,10 @@ def wrapped(
             # req_kwargs is added dynamically by the responses
             # library onto PreparedRequest objects - it is not
             # in the requests type stubs.
-            req_kwargs: dict[str, Any] = getattr(request, "req_kwargs", {})
+            req_kwargs: dict[str, Any] = request.__dict__.get(
+                "req_kwargs",
+                {},
+            )
             timeout: tuple[float, float] | float | int | None = req_kwargs.get(
                 "timeout"
             )
@@ -221,7 +224,10 @@ def __enter__(self) -> Self:
                 compiled_url_pattern = re.compile(pattern=url_pattern)
 
                 for http_method in route.http_methods:
-                    original_callback = getattr(api, route.route_name)
+                    original_callback = object.__getattribute__(
+                        api,
+                        route.route_name,
+                    )
                     mock.add_callback(
                         method=http_method,
                         url=compiled_url_pattern,

src/mock_vws/_respx_mock_server/decorators.py

@@ -161,7 +161,10 @@ def start_respx_router(
             compiled_url_pattern = re.compile(pattern=url_pattern)
 
             for http_method in route.http_methods:
-                original_callback = getattr(api, route.route_name)
+                original_callback = object.__getattribute__(
+                    api,
+                    route.route_name,
+                )
                 router.route(
                     method=http_method,
                     url=compiled_url_pattern,

tests/mock_vws/test_target_validators.py

@@ -71,7 +71,7 @@ def test_validate_target_id_exists_uses_correct_path_segment(
     """
     database = _database_with_target(target_id=target_id)
 
-    monkeypatch.setattr(
+    monkeypatch.setattr(  # pylint: disable=bad-builtin
         target=target_validators,
         name="get_database_matching_server_keys",
         value=partial(_always_match_database, database=database),