Add error handling for missing VuMark database deletion (#2972)

The delete_vumark_database endpoint was missing the try/except ValueError error handling present in delete_cloud_database. When no matching VuMark database exists, the set unpacking raises an unhandled ValueError, resulting in a 500 error instead of a 404 response. Added proper error handling and corresponding tests.

Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>

Author: adamtheturtle

src/mock_vws/_flask_server/target_manager.py

@@ -91,11 +91,15 @@ def delete_vumark_database(database_name: str) -> Response:
 
     :status 200: The VuMark database has been deleted.
     """
-    (matching_database,) = {
-        database
-        for database in TARGET_MANAGER.vumark_databases
-        if database_name == database.database_name
-    }
+    try:
+        (matching_database,) = {
+            database
+            for database in TARGET_MANAGER.vumark_databases
+            if database_name == database.database_name
+        }
+    except ValueError:
+        return Response(response="", status=HTTPStatus.NOT_FOUND)
+
     TARGET_MANAGER.remove_vumark_database(vumark_database=matching_database)
     return Response(response="", status=HTTPStatus.OK)
 

tests/mock_vws/test_flask_app_usage.py

@@ -280,6 +280,33 @@ def test_delete_database() -> None:
         response = requests.delete(url=delete_url, json={}, timeout=30)
         assert response.status_code == HTTPStatus.NOT_FOUND
 
+    @staticmethod
+    def test_vumark_not_found() -> None:
+        """
+        A 404 error is returned when trying to delete a VuMark database
+        which
+        does not exist.
+        """
+        databases_url = _EXAMPLE_URL_FOR_TARGET_MANAGER + "/vumark_databases"
+        delete_url = databases_url + "/" + "foobar"
+        response = requests.delete(url=delete_url, json={}, timeout=30)
+        assert response.status_code == HTTPStatus.NOT_FOUND
+
+    @staticmethod
+    def test_delete_vumark_database() -> None:
+        """It is possible to delete a VuMark database."""
+        databases_url = _EXAMPLE_URL_FOR_TARGET_MANAGER + "/vumark_databases"
+        response = requests.post(url=databases_url, json={}, timeout=30)
+        assert response.status_code == HTTPStatus.CREATED
+
+        data = json.loads(s=response.text)
+        delete_url = databases_url + "/" + data["database_name"]
+        response = requests.delete(url=delete_url, json={}, timeout=30)
+        assert response.status_code == HTTPStatus.OK
+
+        response = requests.delete(url=delete_url, json={}, timeout=30)
+        assert response.status_code == HTTPStatus.NOT_FOUND
+
 
 class TestQueryImageMatchers:
     """Tests for query image matchers."""