Skip to content

app_record: Fix hangup handling during beep and before record loop #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UpBeta merged 1 commit into from
May 23, 2026
+23 −0
Merged

app_record: Fix hangup handling during beep and before record loop #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions apps/app_record.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,8 +461,21 @@ static int record_exec(struct ast_channel *chan, const char *data)
res = ast_streamfile(chan, "beep", ast_channel_language(chan));
if (!res) {
res = ast_waitstream(chan, "");
if (res == -1) {
/* Hangup or error during beep playback */
ast_stopstream(chan);
ast_debug(1, "Channel hangup detected during beep playback on %s\n", ast_channel_name(chan));
status_response = "HANGUP";
goto out;
}
} else {
ast_log(LOG_WARNING, "ast_streamfile(beep) failed on %s\n", ast_channel_name(chan));
if (ast_check_hangup(chan)) {
ast_debug(1, "Channel hangup detected after ast_streamfile failure on %s\n", ast_channel_name(chan));
status_response = "HANGUP";
res = -1;
goto out;
}
res = 0;
}
ast_stopstream(chan);
Expand Down Expand Up @@ -511,6 +524,16 @@ static int record_exec(struct ast_channel *chan, const char *data)
if (maxduration <= 0)
maxduration = -1;

/* Safety net: check for hangup before entering the recording loop.
* This handles the case where hangup arrived after the beep (or with
* the quiet option) but before we start reading frames. */
if (ast_check_hangup(chan)) {
ast_debug(1, "Channel hangup detected before recording loop on %s\n", ast_channel_name(chan));
status_response = "HANGUP";
res = -1;
goto out;
}

start = ast_tvnow();
while ((ms = ast_remaining_ms(start, maxduration))) {
ms = ast_waitfor(chan, ms);
Expand Down