Skip to content

Commit 1e0c842

Browse files
committed
add author_str prop
1 parent 35ca7fe commit 1e0c842

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

uncoder-core/app/translator/core/models/query_container.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,11 @@ def __init__(
7373
self.parsed_logsources = parsed_logsources or {}
7474
self.timeframe = timeframe
7575

76+
@property
77+
def author_str(self) -> Optional[str]:
78+
if self.author:
79+
return ", ".join(self.author)
80+
7681

7782
@dataclass
7883
class RawQueryContainer:

uncoder-core/app/translator/platforms/roota/renders/roota.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ def generate(
131131
rule = copy.deepcopy(ROOTA_RULE_TEMPLATE)
132132
rule["name"] = tokenized_query_container.meta_info.title or _AUTOGENERATED_TEMPLATE
133133
rule["details"] = tokenized_query_container.meta_info.description or rule["details"]
134-
rule["author"] = ", ".join(tokenized_query_container.meta_info.author) or rule["author"]
134+
rule["author"] = tokenized_query_container.meta_info.author_str or rule["author"]
135135
rule["severity"] = tokenized_query_container.meta_info.severity or rule["severity"]
136136
rule["date"] = tokenized_query_container.meta_info.date
137137
rule["detection"]["language"] = rule_query_language

uncoder-core/app/translator/platforms/sigma/renders/sigma.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ def generate_from_tokenized_query_container(self, query_container: TokenizedQuer
299299
"id": meta_info.id,
300300
"description": description_str,
301301
"status": "experimental",
302-
"author": ', '.join(meta_info.author),
302+
"author": query_container.meta_info.author_str,
303303
"references": meta_info.references,
304304
"tags": meta_info.tags,
305305
"logsource": log_source_signature.log_sources,

0 commit comments

Comments
 (0)