Skip to content

Commit 8e111f1

Browse files
myabcclaude
andauthored
🤖 Merge PR DefinitelyTyped#74616 [hotwired__turbo] Tighten resume type in render events by @myabc
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 2de4acc commit 8e111f1

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

‎types/hotwired__turbo/hotwired__turbo-tests.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,13 @@ document.addEventListener("turbo:before-render", function(e) {
114114
// $ExpectType HTMLBodyElement
115115
newElement;
116116
};
117+
// $ExpectType (value?: unknown) => void
118+
e.detail.resume;
119+
});
120+
121+
document.addEventListener("turbo:before-frame-render", function(e) {
122+
// $ExpectType (value?: unknown) => void
123+
e.detail.resume;
117124
});
118125

119126
document.addEventListener("turbo:frame-missing", function(event) {

‎types/hotwired__turbo/index.d.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ export type TurboBeforeRenderEvent = CustomEvent<{
411411
newBody: HTMLBodyElement;
412412
renderMethod: "replace" | "morph";
413413
isPreview: boolean;
414-
resume: (value?: any) => void;
414+
resume: (value?: unknown) => void;
415415
render: (currentBody: HTMLBodyElement, newBody: HTMLBodyElement) => void;
416416
}>;
417417
export type TurboBeforeVisitEvent = CustomEvent<{ url: string }>;
@@ -422,7 +422,7 @@ export type TurboClickEvent = CustomEvent<{
422422
export type TurboFrameLoadEvent = CustomEvent;
423423
export type TurboBeforeFrameRenderEvent = CustomEvent<{
424424
newFrame: FrameElement;
425-
resume: (value?: any) => void;
425+
resume: (value?: unknown) => void;
426426
render: (currentFrame: FrameElement, newFrame: FrameElement) => void;
427427
}>;
428428
export type TurboFrameRenderEvent = CustomEvent<{

0 commit comments

Comments
 (0)