Conversation
issue #6 initial review
Sb issue read me
There was a problem hiding this comment.
Pull request overview
This PR completes the “Sandbox” cookie manager demo by adding cookie grouping support, implementing cookie/group deletion attempts, and updating the demo app + documentation to reflect the new configuration options.
Changes:
- Reworked the cookie manager UI to render cookies grouped under collapsible sections, with per-cookie and per-group delete actions.
- Added group-rules synchronization/validation logic plus cookie deletion attempts (including parent-domain attempts) in the element implementation.
- Updated demo app wiring, dev server script, and README instructions/usage examples.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/elements/cork-cookie-manager.tpl.js | New grouped “grid” UI layout, group header + delete-group button, dev-only test cookie button |
| src/elements/cork-cookie-manager.js | Group rules syncing/validation, cookie grouping, cookie & group deletion logic, dev-only test cookie generation |
| app/public/elements/demo-main.tpl.js | Demo now imports exported rules and renders them; passes group rules into <cork-cookie-manager> |
| app/public/elements/demo-main.js | Adds demo groupRules configuration used by the template |
| app/package.json | Switches demo serve script to node server.js |
| README.md | Updates local dev steps and adds usage/config documentation (group rules + parent domain) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spelkey-ucd
requested changes
Apr 23, 2026
added 2 commits
May 5, 2026 23:53
spelkey-ucd
requested changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed functionality