Skip to content

Commit 1d41f03

Browse files
authored
fix(trogonstack-datadog): add --agent flag to all pup CLI calls (#36)
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
1 parent 3230aab commit 1d41f03

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

  • plugins/trogonstack-datadog/skills/datadog-design-dashboard

plugins/trogonstack-datadog/skills/datadog-design-dashboard/SKILL.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ allowed-tools: AskUserQuestion, Write, Read, Shell
1717

1818
Design a dashboard layout that tells a clear story — from high-level health signals down to granular diagnostics — using proper widget types, group organization, and template variables for reusability.
1919

20-
**Important**: Always check for existing dashboards first with `pup dashboards list`. Do not create a new dashboard if one already exists for the same service or purpose — update the existing one instead. Only create a new dashboard when no relevant one exists or the user explicitly asks for a new one.
20+
**Important**: Always check for existing dashboards first with `pup dashboards list --agent`. Do not create a new dashboard if one already exists for the same service or purpose — update the existing one instead. Only create a new dashboard when no relevant one exists or the user explicitly asks for a new one.
2121

2222
**Philosophy**: The frameworks, layouts, and widget guides in this skill are starting points — not rigid rules. Every product and business is different. Understand the domain first, then adapt the frameworks to fit. The best dashboards reflect how the business actually works, not how a generic template says they should.
2323

@@ -38,7 +38,7 @@ First, determine the mode:
3838
3. **Data Sources** — "Which Datadog products are involved? Metrics only, APM + Metrics, Logs + Metrics, or full stack?"
3939
4. **Scope** — "Is this for a single service, a group of services, or infrastructure-wide?"
4040
5. **Dashboard Strategy** — "One dashboard per service, or a consolidated view?" — share the trade-offs from [references/layouts.md](references/layouts.md) to help them decide. If unsure, ask: "During an outage, does your team investigate one service at a time, or do they need to see all services simultaneously?"
41-
6. **Existing Dashboard** — "Is there an existing dashboard to audit or redesign?" If yes, fetch with `pup dashboards get <id>` before designing.
41+
6. **Existing Dashboard** — "Is there an existing dashboard to audit or redesign?" If yes, fetch with `pup dashboards get <id> --agent` before designing.
4242

4343
### Audit Questions
4444

@@ -80,8 +80,8 @@ Before designing, understand what you are building observability for. The metric
8080
### 1. Gather existing context
8181

8282
```bash
83-
pup dashboards list
84-
pup dashboards get <dashboard-id>
83+
pup dashboards list --agent
84+
pup dashboards get <dashboard-id> --agent
8585
```
8686

8787
If auditing an existing dashboard, fetch its definition first and analyze its current structure before redesigning.
@@ -92,10 +92,10 @@ Before designing widgets, check what metrics and tag values actually exist for t
9292

9393
```bash
9494
# See what metrics are available for the service
95-
pup metrics list --filter="<service-name>.*"
95+
pup metrics list --filter="<service-name>.*" --agent
9696

9797
# Verify the service tag is active and see what metrics are flowing
98-
pup metrics list --filter="trace.*" --tag-filter="service:<service-name>"
98+
pup metrics list --filter="trace.*" --tag-filter="service:<service-name>" --agent
9999
```
100100

101101
Use the actual metric names and tag values you find here when writing widget queries — do not guess or invent them. If a metric you expect does not appear, flag it to the user before building widgets around it.
@@ -159,15 +159,15 @@ These are guiding principles — not a rigid checklist. Apply judgment based on
159159

160160
```bash
161161
# If given a service name, list all dashboards and identify the relevant one by title
162-
pup dashboards list
162+
pup dashboards list --agent
163163

164164
# If given a URL, extract the dashboard ID from the path (e.g., /dashboard/abc-def-ghi/...)
165165

166166
# Get the full dashboard definition (includes the dashboard URL in the response)
167-
pup dashboards get <dashboard-id>
167+
pup dashboards get <dashboard-id> --agent
168168

169169
# Verify real metric names exist
170-
pup metrics list --filter="trace.http.request.*"
170+
pup metrics list --filter="trace.http.request.*" --agent
171171
```
172172

173173
Parse the response to build an inventory of all widgets, groups, and their configurations.
@@ -303,12 +303,12 @@ Compile all findings into a structured report:
303303

304304
## Quality Principles
305305

306-
- [ ] Widget queries use real metric names verified via `pup metrics list` — no invented metric names
306+
- [ ] Widget queries use real metric names verified via `pup metrics list --agent` — no invented metric names
307307
- [ ] Dashboard reflects the actual product and business — metrics tailored to the domain
308308
- [ ] Dashboard title follows `[service] Purpose` pattern — no "Dashboard" suffix, no environment in the title
309309
- [ ] `title` field updated in the JSON (not just the filename) — redeploy after any title change
310310
- [ ] Template variables match the dashboard type — see [references/layouts.md](references/layouts.md)
311-
- [ ] Widget queries use template variable scopes verified via `pup metrics list` — no hardcoded env, service, or host values; use the variable set appropriate for the dashboard type (see [references/layouts.md](references/layouts.md))
311+
- [ ] Widget queries use template variable scopes verified via `pup metrics list --agent` — no hardcoded env, service, or host values; use the variable set appropriate for the dashboard type (see [references/layouts.md](references/layouts.md))
312312
- [ ] **Business group** with 5-8 `B`-prefixed metrics tailored to the service's customer-visible outcomes
313313
- [ ] Groups ordered macro-to-micro (business → overview → details)
314314
- [ ] **Every widget title uses the layer-priority prefix** (`I0:`, `P1:`, `D0:`, `B0:`, etc.) — see [references/widgets.md](references/widgets.md)

0 commit comments

Comments
 (0)