add Store::Initialise based on stringstream rather than string filename. Return false on failure to parse a config file line (which isn't a comment or empty), rather than silently ignoring it

Author: Marcus O'Flaherty

src/Store/Store.cpp

@@ -9,26 +9,51 @@ bool Store::Initialise(std::string filename){
   std::ifstream file(filename.c_str());
   std::string line;
 
+  bool all_ok = true;
   if(file.is_open()){
 
     while (getline(file,line)){
       if (line.size()>0){
-	if (line.at(0)=='#')continue;
-	std::string key;
-	std::string value;
-	std::stringstream stream(line);
-	if(stream>>key>>value) m_variables[key]=value;
+        if(line.at(0)=='#') continue;
+        std::string key;
+        std::string value;
+        std::stringstream stream(line);
+        if(stream>>key>>value) m_variables[key]=value;
+        else {
+          std::cout<<"Store::Initialise failed to parse line '"<<line<<"'"<<std::endl;
+          all_ok = false;
+        }
       }
-      
     }
+    
     file.close();
   }
   else{
     std::cout<<"\033[38;5;196m WARNING!!!: Config file "<<filename<<" does not exist no config loaded \033[0m"<<std::endl;
     return false;
   }
 
-  return true;
+  return all_ok;
+}
+
+bool Store::Initialise(std::stringstream& inputstream){
+
+  bool all_ok = true;
+  std::string line;
+  while(getline(inputstream, line)){
+    if(line.empty()) continue;
+    if(line[0]=='#') continue;
+    std::string key;
+    std::string value;
+    std::stringstream stream(line);
+    if(stream>>key>>value) m_variables[key]=value;
+    else {
+      std::cout<<"Store::Initialise failed to parse line '"<<line<<"'"<<std::endl;
+      all_ok = false;
+    }
+  }
+  
+  return all_ok;
 }
 
 void Store::Print(){

src/Store/Store.h

@@ -24,6 +24,7 @@ class Store{
   Store(); ////< Sinple constructor
 
   bool Initialise(std::string filename); ///< Initialises Store by reading in entries from an ASCII text file, when each line is a variable and its value in key value pairs.  @param filename The filepath and name to the input file.
+  bool Initialise(std::stringstream& inputstream); ///< Initialises Store by reading entries from an ASCII text stream. Each line is a variable and its value in key value pairs. @param inputstream The stream to read from.
   void JsonParser(std::string input); ///<  Converts a flat JSON formatted string to Store entries in the form of key value pairs.  @param input The input flat JSON string.
   void Print(); ///< Prints the contents of the Store.
   void Delete(); ///< Deletes all entries in the Store.