using genreIds and authorIds on Book Post,put

Author: simon

API_DOCUMENTATION.md

@@ -120,19 +120,11 @@ Base Path: `/books`
 
 ```json
 {
-    "name": "The Lord of the Rings",
+    "name": "The Lord he Rings",
     "isbn": "978-3-16-148410-0",
     "publisher": "Klett-Cotta",
-    "genres": [
-        {
-            "id": 1
-        }
-    ],
-    "authors": [
-        {
-            "id": 1
-        }
-    ],
+    "genreIds": [1, 6],
+    "authorIds": [1, 2],
     "availableCopies": 10,
     "totalCopies": 10
 }
@@ -142,20 +134,12 @@ Base Path: `/books`
 
 ```json
 {
-    "name": "The Hobbit",
+    "name": "The Lord he Rings",
     "isbn": "978-3-16-148410-0",
     "publisher": "Klett-Cotta",
-    "genres": [
-        {
-            "id": 1
-        }
-    ],
-    "authors": [
-        {
-            "id": 1
-        }
-    ],
-    "availableCopies": 5,
+    "genreIds": [1, 6],
+    "authorIds": [1, 2],
+    "availableCopies": 10,
     "totalCopies": 10
 }
 ```

src/main/java/com/themetalstorm/bibliothekssystem/controller/BookController.java

@@ -1,5 +1,6 @@
 package com.themetalstorm.bibliothekssystem.controller;
 
+import com.themetalstorm.bibliothekssystem.dto.BookPostDTO;
 import com.themetalstorm.bibliothekssystem.service.BookService;
 import com.themetalstorm.bibliothekssystem.dto.BookDTO;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -41,13 +42,13 @@ ResponseEntity<BookDTO> findById(@PathVariable int id) {
     @PreAuthorize("hasRole('ROLE_ADMIN')")
     @PostMapping("")
     @ResponseBody
-    ResponseEntity<BookDTO> addBook(@RequestBody BookDTO book) {
-        return new ResponseEntity<>(bookService.addBook(book), HttpStatus.CREATED);
+    ResponseEntity<BookDTO> addBook(@RequestBody BookPostDTO book) {
+        return new ResponseEntity<>(bookService.addBookPostDTO(book), HttpStatus.CREATED);
     }
 
     @PreAuthorize("hasRole('ROLE_ADMIN')")
     @PutMapping("/{id}")
-    public ResponseEntity<BookDTO> updateBook(@PathVariable int id, @RequestBody BookDTO bookDTO) {
+    public ResponseEntity<BookDTO> updateBook(@PathVariable int id, @RequestBody BookPostDTO bookDTO) {
         return ResponseEntity.ok(bookService.updateBook(id, bookDTO));
     }
 

src/main/java/com/themetalstorm/bibliothekssystem/dto/BookPostDTO.java

@@ -0,0 +1,9 @@
+package com.themetalstorm.bibliothekssystem.dto;
+
+import org.springframework.boot.context.properties.bind.DefaultValue;
+
+import java.util.Set;
+
+public record BookPostDTO (String name, String isbn, String publisher, Set<Integer> genreIds, Set<Integer> authorIds, @DefaultValue(value = "1") int availableCopies, @DefaultValue(value = "1") int totalCopies){
+
+}

src/main/java/com/themetalstorm/bibliothekssystem/model/Book.java

@@ -1,6 +1,7 @@
 package com.themetalstorm.bibliothekssystem.model;
 
 import com.themetalstorm.bibliothekssystem.dto.BookDTO;
+import com.themetalstorm.bibliothekssystem.dto.BookPostDTO;
 import jakarta.persistence.*;
 import lombok.AllArgsConstructor;
 import lombok.Getter;
@@ -84,6 +85,16 @@ public Book(BookDTO bookDTO) {
     }
 
 
+    public Book(BookPostDTO bookDTO) {
+        this.name = bookDTO.name();
+        this.isbn = bookDTO.isbn();
+        this.publisher = bookDTO.publisher();
+        this.genres = new HashSet<>();
+        this.authors =  new HashSet<>();
+        this.availableCopies = bookDTO.availableCopies();
+        this.totalCopies = bookDTO.totalCopies();
+    }
+
     @Override
     public boolean equals(Object o) {
         if (o == null || getClass() != o.getClass()) return false;

src/main/java/com/themetalstorm/bibliothekssystem/service/BookService.java

@@ -1,6 +1,7 @@
 package com.themetalstorm.bibliothekssystem.service;
 
 import com.themetalstorm.bibliothekssystem.dto.AuthorDTO;
+import com.themetalstorm.bibliothekssystem.dto.BookPostDTO;
 import com.themetalstorm.bibliothekssystem.dto.GenreDTO;
 import com.themetalstorm.bibliothekssystem.exceptions.ResourceAlreadyExistsException;
 import com.themetalstorm.bibliothekssystem.model.Author;
@@ -79,25 +80,44 @@ public BookDTO addBook(BookDTO bookDTO) {
         return new BookDTO(bookRepository.save(book));
     }
 
-    public BookDTO updateBook(int id, BookDTO bookDTO) {
+    public BookDTO addBookPostDTO(BookPostDTO bookDTO) {
+
+        boolean isbnExists = bookRepository.existsByIsbn(bookDTO.isbn());
+        if(isbnExists){
+            throw new ResourceAlreadyExistsException("Books with ISBN " + bookDTO.isbn() + " already exists");
+        }
+
+        Book book = new Book(bookDTO);
+        for (Integer authorId : bookDTO.authorIds()) {
+            Author existingAuthor = authorRepository.findById(authorId).orElseThrow(() -> new ResourceNotFoundException("Genre not found with id: " + authorId));
+            book.getAuthors().add(existingAuthor);
+        }
+
+        for (Integer genreId : bookDTO.genreIds()) {
+            Genre existingGenre = genreRepository.findById(genreId).orElseThrow(() -> new ResourceNotFoundException("Genre not found with id: " + genreId));
+            book.getGenres().add(existingGenre);
+        }
+
+        return new BookDTO(bookRepository.save(book));
+    }
+
+    public BookDTO updateBook(int id, BookPostDTO bookDTO) {
         Book book = bookRepository.findById(id).orElseThrow(() -> new ResourceNotFoundException("Book not found with id: " + id));
         book.setName(bookDTO.name());
         book.setIsbn(bookDTO.isbn());
         book.setAvailableCopies(bookDTO.availableCopies());
         book.setTotalCopies(bookDTO.totalCopies());
 
         book.getAuthors().clear();
-        for (AuthorDTO authorDTO : bookDTO.authors()) {
-            Author author = authorRepository.findByFirstNameAndLastName(authorDTO.firstName(), authorDTO.lastName())
-                    .orElseGet(() -> authorRepository.save(new Author(authorDTO)));
-            book.getAuthors().add(author);
+        for (Integer authorId : bookDTO.authorIds()) {
+            Author existingAuthor = authorRepository.findById(authorId).orElseThrow(() -> new ResourceNotFoundException("Genre not found with id: " + authorId));
+            book.getAuthors().add(existingAuthor);
         }
 
         book.getGenres().clear();
-        for (GenreDTO genreDTO : bookDTO.genres()) {
-            Genre genre = genreRepository.findByName(genreDTO.name())
-                    .orElseGet(() -> genreRepository.save(new Genre(genreDTO)));
-            book.getGenres().add(genre);
+        for (Integer genreId : bookDTO.genreIds()) {
+            Genre existingGenre = genreRepository.findById(genreId).orElseThrow(() -> new ResourceNotFoundException("Genre not found with id: " + genreId));
+            book.getGenres().add(existingGenre);
         }
 
         return new BookDTO(bookRepository.save(book));