Skip to content

Commit 07c3f1b

Browse files
author
simon
committed
fixed small bug where on post genre we dont return a body
1 parent 559ec36 commit 07c3f1b

3 files changed

Lines changed: 4 additions & 7 deletions

File tree

src/main/java/com/themetalstorm/bibliothekssystem/controller/BookController.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ public ResponseEntity<BookDTO> updateBook(@PathVariable int id, @RequestBody Boo
5252
return ResponseEntity.ok(bookService.updateBook(id, bookDTO));
5353
}
5454

55-
//TODO: PUT
56-
5755
@PreAuthorize("hasRole('ROLE_ADMIN')")
5856
@DeleteMapping("/{id}")
5957
ResponseEntity<Void> deleteBook(@PathVariable int id) {

src/main/java/com/themetalstorm/bibliothekssystem/controller/GenreController.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,8 @@ ResponseEntity<GenreDTO> findById(@PathVariable int id) {
3737
@PreAuthorize("hasRole('ROLE_ADMIN')")
3838
@PostMapping("")
3939
@ResponseBody
40-
ResponseEntity<Void> addGenre(@RequestBody GenreDTO genre) {
41-
genreService.addGenre(genre);
42-
return new ResponseEntity<>(HttpStatus.CREATED);
40+
ResponseEntity<GenreDTO> addGenre(@RequestBody GenreDTO genre) {
41+
return new ResponseEntity<>(genreService.addGenre(genre), HttpStatus.CREATED);
4342
}
4443

4544
@PreAuthorize("hasRole('ROLE_ADMIN')")

src/main/java/com/themetalstorm/bibliothekssystem/service/GenreService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ public GenreService(GenreRepository genreRepository) {
2626
this.genreRepository = genreRepository;
2727
}
2828

29-
public void addGenre(GenreDTO genre) {
29+
public GenreDTO addGenre(GenreDTO genre) {
3030
if (genreRepository.existsByName(genre.name())) {
3131
throw new ResourceAlreadyExistsException("Genre with name " + genre.name() + " already exists");
3232
}
33-
genreRepository.save(new Genre(genre));
33+
return new GenreDTO(genreRepository.save(new Genre(genre)));
3434
}
3535

3636
public Page<GenreDTO> getAllGenres(Integer page, Integer size, String sortField, String sortDirection) {

0 commit comments

Comments
 (0)