Update feature

[marek2001]

Pre-submit checks

• I checked for similar issues beforehand, but could not find any, not even closed ones. I could not add my bug report to any existing issue.
• I am going to take the time to to fill in all the required details. I know that the bug report will be dismissed otherwise.

Describe the bug

-DENABLE_UPDATE_HELPER=ON \ to cmake

But even after ignoring some "compile warnings treated as errors", it still won't build (error in "build/_deps/cpr-src/cpr/").

Is update feature implemented already?

Expected behavior

Update feature show green checkmark in appimage launcher settings.

Steps to reproduce the issue

export PREFIX="/usr/local/"
mkdir build
cd build

cmake .. -DCMAKE_INSTALL_PREFIX="$PREFIX" -DUSE_SYSTEM_BOOST=true -DENABLE_UPDATE_HELPER=ON

See #251 for more details why this is required

make libappimage libappimageupdate libappimageupdate-qt
cmake .

make

Screenshots

No response

Distribution and desktop environment

CachyOS KDE 6.5.3

Installed AppImageLauncher version

3.0.0_beta_3-1

List of AppImages you tried (ideally with URL)

No response

Additional context

No response

[shayaknyc]

Found this thread when searching for a similar problem. I'm trying to compile based off the AUR package, which downloads the upstream release from this repo. Have the same -DENABLE_UPDATE_HELPER=ON added to cmake. This is the error output I'm getting:

[ 12%] Building C object _deps/zsync2-build/lib/libzsync/CMakeFiles/libzsync.dir/zsync.c.o
/home/user/git/appimagelauncher/src/build/_deps/zsync2-src/lib/libzsync/zsync.c: In function ‘zsync_get_urls’:
/home/user/git/appimagelauncher/src/build/_deps/zsync2-src/lib/libzsync/zsync.c:460:18: error: returning ‘char **’ from a function with incompatible return type ‘const char * const*’ [-Wincompatible-pointer-types]
  460 |         return zs->zurl;
      |                ~~^~~~~~
/home/user/git/appimagelauncher/src/build/_deps/zsync2-src/lib/libzsync/zsync.c:465:18: error: returning ‘char **’ from a function with incompatible return type ‘const char * const*’ [-Wincompatible-pointer-types]
  465 |         return zs->url;
      |                ~~^~~~~
/home/user/git/appimagelauncher/src/build/_deps/zsync2-src/lib/libzsync/zsync.c: In function ‘zsync_receive_data_compressed’:
/home/user/git/appimagelauncher/src/build/_deps/zsync2-src/lib/libzsync/zsync.c:945:22: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  945 |     zr->strm.next_in = buf;
      |                      ^
/home/user/git/appimagelauncher/src/build/_deps/zsync2-src/lib/libzsync/zsync.c:950:43: error: passing argument 4 of ‘zsync_configure_zstream_for_zdata’ from incompatible pointer type [-Wincompatible-pointer-types]
  950 |                                           &(zr->outoffset));
      |                                           ^~~~~~~~~~~~~~~~
      |                                           |
      |                                           off_t * {aka long int *}
/home/user/git/appimagelauncher/src/build/_deps/zsync2-src/lib/libzsync/zsync.c:791:65: note: expected ‘long long int *’ but argument is of type ‘off_t *’ {aka ‘long int *’}
  791 |                                        long zoffset, long long *poutoffset) {
      |                                                      ~~~~~~~~~~~^~~~~~~~~~
/home/user/git/appimagelauncher/src/build/_deps/zsync2-src/lib/libzsync/zsync.c:962:26: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  962 |         zr->strm.next_in = buf;
      |                          ^
make[2]: *** [_deps/zsync2-build/lib/libzsync/CMakeFiles/libzsync.dir/build.make:79: _deps/zsync2-build/lib/libzsync/CMakeFiles/libzsync.dir/zsync.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1179: _deps/zsync2-build/lib/libzsync/CMakeFiles/libzsync.dir/all] Error 2
make: *** [Makefile:156: all] Error 2
==> ERROR: A failure occurred in build().
    Aborting...

When -DENABLE_UPDATE_HELPER=ON is removed, it compiles just fine with no issue.

[Koli0842]

I am getting the same error as shayaknyc. It would be an important convenience feature to help appimage adoption for sure