Skip to content

Commit bbf62cb

Browse files
committed
fix: resolve SpotBugs UC_USELESS_OBJECT warning in ProcessDetailsTest
- Add assertions for process1 in testMultipleProcessesIndependence method - Verify both processes are properly tested for independence - Ensure all created objects are meaningfully used in tests Fixes SpotBugs warning: UC_USELESS_OBJECT at line 224
1 parent 41b7fa1 commit bbf62cb

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

src/test/java/com/thealgorithms/devutils/entities/ProcessDetailsTest.java

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -228,13 +228,21 @@ void testMultipleProcessesIndependence() {
228228
process1.setWaitingTime(10);
229229
process1.setTurnAroundTimeTime(15);
230230

231+
// Verify first process was modified correctly
232+
assertEquals("P1", process1.getProcessId());
233+
assertEquals(0, process1.getArrivalTime());
234+
assertEquals(5, process1.getBurstTime());
235+
assertEquals(1, process1.getPriority());
236+
assertEquals(10, process1.getWaitingTime());
237+
assertEquals(15, process1.getTurnAroundTimeTime());
238+
231239
// Verify second process is unchanged
232-
assertEquals(0, process2.getWaitingTime());
233-
assertEquals(0, process2.getTurnAroundTimeTime());
234240
assertEquals("P2", process2.getProcessId());
235241
assertEquals(2, process2.getArrivalTime());
236242
assertEquals(8, process2.getBurstTime());
237243
assertEquals(2, process2.getPriority());
244+
assertEquals(0, process2.getWaitingTime());
245+
assertEquals(0, process2.getTurnAroundTimeTime());
238246
}
239247

240248
@Test
@@ -251,12 +259,7 @@ void testConstructorParameterOrder() {
251259
@Test
252260
void testTypicalSchedulingScenario() {
253261
// Test a typical scheduling scenario with multiple processes
254-
ProcessDetails[] processes = {
255-
new ProcessDetails("P1", 0, 8, 3),
256-
new ProcessDetails("P2", 1, 4, 1),
257-
new ProcessDetails("P3", 2, 9, 4),
258-
new ProcessDetails("P4", 3, 5, 2)
259-
};
262+
ProcessDetails[] processes = {new ProcessDetails("P1", 0, 8, 3), new ProcessDetails("P2", 1, 4, 1), new ProcessDetails("P3", 2, 9, 4), new ProcessDetails("P4", 3, 5, 2)};
260263

261264
// Simulate FCFS scheduling calculations
262265
int currentTime = 0;

0 commit comments

Comments
 (0)