syn: Fix combinational mapper; extend tests#10495
Merged
povik merged 5 commits intoMay 23, 2026
Merged
Conversation
Partially revert a recent tidying commit which introduced a bug by removing those casts. Signed-off-by: Martin Povišer <povik@cutebit.org>
Assisted-by: Claude (various models) Signed-off-by: Martin Povišer <povik@cutebit.org>
Assisted-by: Claude (various models) Signed-off-by: Martin Povišer <povik@cutebit.org>
Assisted-by: Claude (various models) Signed-off-by: Martin Povišer <povik@cutebit.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new combinational mapping test suite (cm_test) with associated liberty files and build system updates. It also enhances the IR parser with output width validation, fixes signed/unsigned comparison warnings in the combinational mapper, and updates Bazel scripts to prevent recursive submodule traversal. A review comment suggests refactoring the width validation logic in Parse.cc to improve readability by using a local variable for the calculated slot count.
Comment on lines
+542
to
+547
| const uint32_t expected_slots = std::max(width, 1u); | ||
| if (g->tableSize() != id + expected_slots) { | ||
| error("'" + keyword + "' declared output width " + std::to_string(width) | ||
| + " but produced " + std::to_string(g->tableSize() - id) + " slot" | ||
| + (g->tableSize() - id == 1 ? "" : "s")); | ||
| } |
Contributor
There was a problem hiding this comment.
The calculation g->tableSize() - id is repeated multiple times in this block. Storing this value in a local variable (e.g., actual_slots) would improve code readability and maintainability by making the validation logic more explicit and avoiding redundant calculations.
Suggested change
| const uint32_t expected_slots = std::max(width, 1u); | |
| if (g->tableSize() != id + expected_slots) { | |
| error("'" + keyword + "' declared output width " + std::to_string(width) | |
| + " but produced " + std::to_string(g->tableSize() - id) + " slot" | |
| + (g->tableSize() - id == 1 ? "" : "s")); | |
| } | |
| const uint32_t actual_slots = g->tableSize() - id; | |
| const uint32_t expected_slots = std::max(width, 1u); | |
| if (actual_slots != expected_slots) { | |
| error("'" + keyword + "' declared output width " + std::to_string(width) | |
| + " but produced " + std::to_string(actual_slots) + " slot" | |
| + (actual_slots == 1 ? "" : "s")); | |
| } |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
reviewed
May 22, 2026
Comment on lines
+678
to
+679
| for (int i = -1; i < (int) cache[n1->fid].ps.size(); i++) { | ||
| for (int j = -1; j < (int) cache[n2->fid].ps.size(); j++) { |
maliberty
approved these changes
May 22, 2026
Member
|
Signed-off-by: Martin Povišer <povik@cutebit.org>
povik
requested review from
a team and
precisionmoon
and removed request for
a team
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Undo the collateral damage done in 169f2b2 and extend test coverage to make sure we will catch it next time. Resolves the issue reported in #10492
Type of Change
Impact
Verification
./etc/Build.sh).