-
Notifications
You must be signed in to change notification settings - Fork 899
syn: minimal Bazel repro for SIGSEGV in syn::map_combinationals (post-#10473) #10492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oharboe
wants to merge
4
commits into
The-OpenROAD-Project:master
Choose a base branch
from
oharboe:syn-sigsegv-minimal-repro
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+71
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3377f0e
syn: minimal Bazel repro for SIGSEGV in syn::map_combinationals
oharboe f7756e9
syn: address PR #10492 review nits
oharboe a324051
syn: address PR #10492 review nits
oharboe eca09b8
syn: drop redundant ./ prefix on Tcl script argument
oharboe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| #!/usr/bin/env bash | ||
| # Wrapper for sh_test targets that run the openroad binary against a Tcl | ||
| # repro. | ||
| # | ||
| # Bazel's sh_test sets cwd to the runfiles workspace root before | ||
| # invoking this script, so test data (asap7 lib files, the .sv RTL, | ||
| # the openroad binary itself) is reachable via "./" relative paths | ||
| # without any explicit cd or workspace-name detection. | ||
| # | ||
| # args: | ||
| # $1 - rootpath to the openroad binary | ||
| # $2 - rootpath to the Tcl script | ||
| set -euo pipefail | ||
| OPENROAD_BIN="$1" | ||
| TCL="$2" | ||
| # The "./" prefix on the binary is needed so exec resolves it relative | ||
| # to cwd rather than PATH-searching; the Tcl script is just a file | ||
| # argument and goes through openroad's own open(), which handles both | ||
| # relative-to-cwd and absolute paths without it. | ||
| exec "./${OPENROAD_BIN}" -no_splash -no_init -exit "${TCL}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| module synthesize_minimal_and (input wire a, input wire b, output wire q); | ||
| assign q = a & b; | ||
| endmodule |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Minimal reproducer for a SIGSEGV in syn::map_combinationals (the post-ABC | ||
| # mapper introduced in #10473). Any design with at least one AND node in | ||
| # the post-ABC AIG crashes; a single 2-input AND is the smallest input | ||
| # that triggers it. | ||
| # | ||
| # Expected behavior once fixed: synthesize completes and "OK" is printed. | ||
| # Current behavior: SIGSEGV inside syn::map_combinationals immediately | ||
| # after the "[INFO SYN-0023] abc_roundtrip: after ABC: 1 ANDs ..." log line. | ||
| # | ||
| # Paths are workspace-root-relative; the wrapper sh_test cd's into the | ||
| # Bazel runfiles workspace before invoking openroad. | ||
|
|
||
| read_lef test/asap7/asap7_tech_1x_201209.lef | ||
| read_lef test/asap7/asap7sc7p5t_28_R_1x_220121a.lef | ||
| read_liberty test/asap7/asap7sc7p5t_AO_RVT_FF_nldm_211120.lib.gz | ||
| read_liberty test/asap7/asap7sc7p5t_INVBUF_RVT_FF_nldm_220122.lib.gz | ||
| read_liberty test/asap7/asap7sc7p5t_OA_RVT_FF_nldm_211120.lib.gz | ||
| read_liberty test/asap7/asap7sc7p5t_SIMPLE_RVT_FF_nldm_211120.lib.gz | ||
| read_liberty test/asap7/asap7sc7p5t_SEQ_RVT_FF_nldm_220123.lib | ||
|
|
||
| sv_elaborate -D SYNTHESIS --top synthesize_minimal_and --std=1364-2005 \ | ||
| src/syn/test/synthesize_minimal_and.sv | ||
| syn::stats | ||
| synthesize | ||
|
|
||
| puts "OK" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.