Skip to content

bazel-orfs: bump to 6ebadeb (yosys/abc 0.64 via custom registry)#4254

Open
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:bazel-orfs-bump-yosys-0.64
Open

bazel-orfs: bump to 6ebadeb (yosys/abc 0.64 via custom registry)#4254
oharboe wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:bazel-orfs-bump-yosys-0.64

Conversation

@oharboe
Copy link
Copy Markdown
Collaborator

@oharboe oharboe commented May 23, 2026

Summary

  • Bumps BAZEL_ORFS_COMMIT to 6ebadeb, which pins yosys to 0.64 to pick up the Kogge-Stone adder memory-corruption fix that triggered ABC SIGSEGVs under yosys 0.63.
  • Drops the vendored render_gds PDK_CONFIGS patch (and the now-empty patches/bazel-orfs/ dir) — the fix landed upstream in bazel-orfs bfd3a1d.
  • Mirrors bazel-orfs/.bazelrc's --registry= lines into root .bazelrc so yosys 0.64 resolves from the unmerged BCR PR (bazelbuild/bazel-central-registry#8862) fork until that PR lands. ORFS has its own .bazelrc, so bazel-orfs's lines don't propagate automatically. abc 0.64-yosyshq.bcr.1 is already on official BCR; only yosys 0.64 needs the fallback.

Test plan

  • bazelisk mod graph resolves yosys@0.64 + abc@0.64-yosyshq.bcr.1
  • bazelisk test //flow/designs/asap7/... --keep_goingmock-alu (kogge-stone exerciser) PASSED with yosys/abc 0.64
  • CI run on this PR

Local test summary (9 pass / 7 metric-fail / 2 fail-to-build)

Result Tests
PASS aes, aes-mbff, cva6, ethmac_lvt, gcd, gcd-ccs, jpeg, mock-alu, mock-cpu
rules-base.json metric-miss (synthesis output shift from yosys 0.64; regenerate via make update_ok) aes_lvt, ethmac, ibex, jpeg_lvt, riscv32i, swerv_wrapper, uart
PDN-0233 at floorplan (failed to build) aes-block, riscv32i-mock-sram

The PDN-0233 failures are at floorplan/PDN (post-synthesis) so they are not caused by yosys; flagging here for follow-up since they reproduce on this branch.

🤖 Generated with Claude Code

Picks up the Kogge-Stone adder memory corruption fix in yosys 0.64
that triggered ABC SIGSEGVs under yosys 0.63 + abc 0.62-yosyshq.

- Bump BAZEL_ORFS_COMMIT to 6ebadeb, which moves yosys to 0.64.
- Drop the vendored render_gds PDK_CONFIGS patch and the now-empty
  patches/bazel-orfs/ directory: the fix landed upstream in bazel-orfs
  commit bfd3a1d ("render_gds: monkey-patch PDK_CONFIGS instead of
  gdsii_use_custom_config"), so the patches= argument and its sole
  entry are no longer needed.
- Mirror bazel-orfs/.bazelrc's --registry= lines into root .bazelrc so
  yosys 0.64 resolves from the unmerged BCR PR (bazelbuild/bazel-
  central-registry#8862) fork until that PR lands. ORFS has its own
  .bazelrc, so bazel-orfs's lines don't propagate automatically.
- abc 0.64-yosyshq.bcr.1 is already on official BCR; only yosys 0.64
  requires the fallback registry.

Local test: bazelisk test //flow/designs/asap7/... --keep_going:
mock-alu (kogge-stone exerciser) PASSES with yosys/abc 0.64.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the bazel-orfs dependency to a newer commit, removes a previously vendored patch that has been merged upstream, and configures fallback Bazel registries to accommodate Yosys 0.64. Feedback indicates that the Yosys update has introduced synthesis shifts resulting in "metric-miss" test failures and build regressions (PDN-0233). It is recommended to include the necessary baseline updates and address these build failures within this PR to ensure CI remains green.

Comment thread MODULE.bazel
bazel_dep(name = "bazel-orfs-verilog", dev_dependency = True)

BAZEL_ORFS_COMMIT = "3a5ddd7eb48c363717e65903ae4573d528327fd3"
BAZEL_ORFS_COMMIT = "6ebadeb4be5c9ada103081c9a5e668c014126616"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pull request description indicates that 7 tests are failing with a "metric-miss" due to synthesis output shifts introduced by Yosys 0.64. These baseline updates (e.g., to rules-base.json) should be included in this pull request to ensure that the CI remains green and the repository stays in a consistent state.

Comment thread MODULE.bazel
bazel_dep(name = "bazel-orfs-verilog", dev_dependency = True)

BAZEL_ORFS_COMMIT = "3a5ddd7eb48c363717e65903ae4573d528327fd3"
BAZEL_ORFS_COMMIT = "6ebadeb4be5c9ada103081c9a5e668c014126616"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The 2 "fail-to-build" (PDN-0233) errors mentioned in the summary represent a regression in the build process. Synthesis changes from the Yosys 0.64 bump can impact downstream stages like floorplanning and PDN. These failures should be addressed to ensure that all designs in the test suite continue to build successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant