Summary
Once TangleML/tangle#188 lands, update RunSection to pass a page_size query param to the backend so the number of fetched rows matches what the viewport can display.
Motivation
The Dashboard homepage currently uses maxItems to slice backend results client-side. This means we always over-fetch and page tokens skip sliced items. Passing page_size will make fetches exact and pagination correct.
Changes Needed
- Add
pageSize?: number prop to RunSection
- Pass it as
page_size query param in the fetch URL (alongside page_token, filter_query, etc.)
- Update
DashboardHomeView and DashboardRunsView to pass dynamicRows as pageSize instead of maxItems
- Remove
maxItems slicing once pageSize is wired up
Depends On
Related
Summary
Once TangleML/tangle#188 lands, update
RunSectionto pass apage_sizequery param to the backend so the number of fetched rows matches what the viewport can display.Motivation
The Dashboard homepage currently uses
maxItemsto slice backend results client-side. This means we always over-fetch and page tokens skip sliced items. Passingpage_sizewill make fetches exact and pagination correct.Changes Needed
pageSize?: numberprop toRunSectionpage_sizequery param in the fetch URL (alongsidepage_token,filter_query, etc.)DashboardHomeViewandDashboardRunsViewto passdynamicRowsaspageSizeinstead ofmaxItemsmaxItemsslicing oncepageSizeis wired upDepends On
Related