AutoDrive Giants AI Helper Hand-over Fix Report

[83BitTwitch]

AutoDrive Giants AI Helper Hand-over Fix Report

Hello AutoDrive team,

I wanted to share a tested fix for the Giants vanilla AI helper hand-over issue.

This is about the problem where AutoDrive reaches a field marker and starts the Giants AI helper, but the tractor drives back to the field where it worked previously instead of starting work on the current field.

This seems to be the same issue as AutoDrive GitHub issue #122:

"Enable AI at dest sends Giants AI to wrong field."

I know issue #122 was closed as wontfix / not planned, but we tested a small code change that appears to fix the Giants vanilla AI hand-over without breaking Courseplay hand-over.

Confirmed behaviour

• AutoDrive marker is placed inside the correct field.
• Manual Giants helper start works correctly on the new field.
• Courseplay hand-over works correctly.
• Problem only happens when AutoDrive starts the vanilla Giants helper.
• First Giants AI hand-over works.
• Second Giants AI hand-over with the same tractor on a different field reuses the old field and drives back there.

Root cause found

In:

scripts/Specialization.lua

inside the Giants AI hand-over logic, AutoDrive uses:

local fieldJob = vehicle:getLastJob()

That means if the tractor has already done a Giants AI job before, AutoDrive reuses the old AI job.

That old job still contains the previous field / old fieldwork target, so when AutoDrive starts the helper again, the tractor drives back to the old field.

Original logic

local fieldJob = vehicle:getLastJob()
if fieldJob == nil then
    -- no job present - generate fieldwork job new
    fieldJob = g_currentMission.aiJobTypeManager:createJob(AIJobType.FIELDWORK)
end

Working fix tested

Instead of reusing vehicle:getLastJob(), always create a fresh Giants fieldwork job when AutoDrive hands over to the vanilla Giants helper.

-- Always create a fresh Giants fieldwork job at the current AD destination.
-- Do not reuse vehicle:getLastJob(), because that can point to the old field.
local fieldJob = g_currentMission.aiJobTypeManager:createJob(AIJobType.FIELDWORK)

Also, this line needs to use true at the end:

fieldJob:applyCurrentState(vehicle, g_currentMission, vehicle:getOwnerFarmId(), true)

instead of:

fieldJob:applyCurrentState(vehicle, g_currentMission, vehicle:getOwnerFarmId(), false)

Full tested replacement section

if vehicle.getLastJob then
    if vehicle.getIsOnField and vehicle:getIsOnField() then
        AutoDrive.debugPrint(vehicle, AutoDrive.DC_EXTERNALINTERFACEINFO, "AutoDrive.passToExternalMod pass to Giants AI with fresh fieldwork job")

        -- Always create a fresh Giants fieldwork job at the current AD destination.
        -- Do not reuse vehicle:getLastJob(), because that can point to the old field.
        local fieldJob = g_currentMission.aiJobTypeManager:createJob(AIJobType.FIELDWORK)

        if fieldJob then
            fieldJob:applyCurrentState(vehicle, g_currentMission, vehicle:getOwnerFarmId(), true)
            fieldJob:setValues()

            local success, errorMessage = fieldJob:validate(vehicle:getOwnerFarmId())

            if success then
                AutoDrive.debugPrint(vehicle, AutoDrive.DC_EXTERNALINTERFACEINFO, "AutoDrive.passToExternalMod fresh AI fieldwork job startJob")
                g_currentMission.aiSystem:startJob(fieldJob, vehicle:getOwnerFarmId())
                return
            else
                AutoDrive.debugPrint(vehicle, AutoDrive.DC_EXTERNALINTERFACEINFO, "AutoDrive.passToExternalMod fresh AI fieldwork job validation failed: %s", tostring(errorMessage))
            end
        end
    end
else
    return
end

Tested result

After this change:

• Courseplay hand-over still works.
• Giants vanilla AI helper hand-over works.
• Same tractor can be sent by AutoDrive to one field, start Giants AI, then later be sent to another field, and Giants AI starts on the new field instead of returning to the old one.

Summary

The issue appears to be caused by AutoDrive reusing the previous Giants AI job through:

vehicle:getLastJob()

For Giants vanilla AI hand-over, it works better to create a fresh:

AIJobType.FIELDWORK

from the tractor’s current position when AutoDrive reaches the field marker.

[Axel32019]

Hello @83BitTwitch,

Thanks for looking into this!

What happens with a seeder, spreader etc. if the leave a field to refill seeds, fertilizer, lime... and return to the field?
I guess they will start from the beginning and work on the same area again and again...

To get working what you expect there needs to be done more things.
Let's see what we can do here...

[83BitTwitch]

Hello Axel,

Yes, I understand your concern about seeders/spreaders leaving the field to refill and then returning.

From my experience, Giants AI already tends to restart from the beginning if you manually leave the field, go to refill, and then start the helper again. So I agree this workflow may need more testing, and I will test it properly with a seeder/spreader.

The main issue I was trying to solve is the different-field case:

1. Send the tractor with AutoDrive to Field A.
2. AutoDrive starts Giants AI.
3. Giants AI works Field A correctly.
4. Later send the same tractor with AutoDrive to Field B.
5. AutoDrive starts Giants AI again.
6. Instead of working Field B, it drives back to Field A.

At the moment this makes Giants AI hand-over almost unusable, because the helper remembers the first field it ever worked on and keeps returning there.

Courseplay hand-over should not be affected by this change.

I understand that the final solution may need more logic for refill/return-to-same-field workflows. But in my opinion, creating a fresh fieldwork job when AutoDrive starts Giants AI on a new field is still better than the current situation where Giants AI cannot reliably be used on different fields.

I will test the seeder/spreader refill case and report back.

[Axel32019]

You may now implement "AutoDrive.USER_GIANTS" compareable to "AutoDrive.USER_PLAYER".

[83BitTwitch]

USER_GIANTS Patch Test Report

Hello Axel / AutoDrive team,

I tested the clean USER_GIANTS version.

Files changed

scripts/ExternalInterface.lua
scripts/Modes/PickupAndDeliverMode.lua
scripts/Specialization.lua

No gameplay change in:

scripts/AutoDrive.lua

Temporary test log markers were removed.

What changed

scripts/ExternalInterface.lua

AutoDrive jobs started from a Giants AI refill / return context are now marked as AutoDrive.USER_GIANTS:

vehicle.ad.stateModule:getCurrentMode():start(AutoDrive.USER_GIANTS)

scripts/Modes/PickupAndDeliverMode.lua

The AutoDrive start source is stored:

self.vehicle.ad.startUser = user or AutoDrive.USER_PLAYER

scripts/Specialization.lua

Normal AutoDrive delivery to a field now creates a fresh Giants fieldwork job from the current position:

fieldJob = g_currentMission.aiJobTypeManager:createJob(AIJobType.FIELDWORK)
fieldJob:applyCurrentState(vehicle, g_currentMission, vehicle:getOwnerFarmId(), true)

Giants AI refill / return starts still prefer the old resume behaviour:

fieldJob = vehicle:getLastJob()
fieldJob:applyCurrentState(vehicle, g_currentMission, vehicle:getOwnerFarmId(), false)

The driver-character issue was fixed by keeping:

AutoDriveStartStopEvent:sendStopEvent(self, isPassingToCP, isStartingAIVE)

and not treating Giants AI hand-over like Courseplay hand-over.

Tested result

• Courseplay hand-over works.
• Giants AI hand-over works.
• Same tractor can be sent to Field A, then later Field B.
• Giants AI starts on the current field instead of returning to the old field.
• Old vehicle:getLastJob() resume path is still kept for AutoDrive.USER_GIANTS.
• Permanent driver / character in cab issue is fixed.

Summary

This keeps both behaviours:

• AutoDrive.USER_GIANTS = resume previous Giants AI job.
• Normal AutoDrive field delivery = create fresh AIJobType.FIELDWORK from current position.

[Axel32019]

Hello @83BitTwitch,
Please create a PR for this.