[142] Changes kharidiron requested

Author: 8r2y5

plugins/poi_plugin/poi_plugin.py

@@ -22,7 +22,7 @@ def activate(self):
             'player_manager_plugin'
         ].player_manager
         try:
-            with open(os.path.join('config', 'pois.json')) as f:
+            with open(os.path.join('config', 'pois.json'), 'r') as f:
                 self.pois = json.load(f)
         except:
             self.pois = []
@@ -93,10 +93,7 @@ def poi(self, name):
         """
         name = ' '.join(name).strip().strip('\t')
         if not name:
-            warps = []
-            for warp in self.pois:
-                if warps:
-                    warps.append(warp[1])
+            warps = [warp[1] for warp in self.pois]
             warpnames = '^green;, ^yellow;'.join(warps)
             if not warpnames:
                 warpnames = '^gray;(none)^green;'
@@ -173,7 +170,7 @@ def spawn(self, data):
 
     def savepois(self):
         try:
-            with open(os.path.join('config' 'pois.json', 'wb')) as f:
+            with open(os.path.join('config', 'pois.json'), 'wb') as f:
                 json.dump(self.pois, f)
         except:
             self.logger.exception('Couldn\'t save PoI\'s.')

tests/test_plugin_manager.py

@@ -247,3 +247,10 @@ def test_route_response_false(
 
         mock_pm.do.assert_called_with(mock_self, 'on', 'data')
         self.assertFalse(mock_defer.called)
+
+    @patch.object(PluginManager, 'deactivate_plugins')
+    def test_die(self, mock_deactivate):
+        plugin_manager = PluginManager(Mock())
+
+        plugin_manager.die()
+        self.assertTrue(mock_deactivate.called)