Skip to content

Commit 0b8b4c9

Browse files
authored
Adding Last Verified to the get_tape output (#209)
1 parent d6bee90 commit 0b8b4c9

2 files changed

Lines changed: 22 additions & 21 deletions

File tree

ds3_java_cli/src/main/java/com/spectralogic/ds3cli/views/cli/GetTapesView.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public String render(final GetTapesResult getTapesResult) {
4949

5050
this.getTapesResult = getTapesResult;
5151

52-
initTable(ImmutableList.of("Bar Code", "ID", "State", "Last Modified", "Available Raw Capacity", "BucketID", "Assigned to Storage Domain", "Ejection Date", "Ejection Location", "Ejection Label", "Ejection Pending"));
52+
initTable(ImmutableList.of("Bar Code", "ID", "State", "Last Modified", "Last Verified", "Available Raw Capacity", "BucketID", "Assigned to Storage Domain", "Ejection Date", "Ejection Location", "Ejection Label", "Ejection Pending"));
5353

5454
return ASCIITable.getInstance().getTable(getHeaders(), formatTableContents());
5555
}
@@ -65,13 +65,14 @@ protected String[][] formatTableContents() {
6565
bucketArray[1] = nullGuardToString(tape.getId());
6666
bucketArray[2] = nullGuardToString(tape.getState());
6767
bucketArray[3] = nullGuardFromDate(tape.getLastModified(), DATE_FORMAT);
68-
bucketArray[4] = nullGuardToString(tape.getAvailableRawCapacity());
69-
bucketArray[5] = nullGuardToString(tape.getBucketId());
70-
bucketArray[6] = nullGuardToString(storageDomainName(tape));
71-
bucketArray[7] = nullGuardFromDate(tape.getEjectDate(), DATE_FORMAT);
72-
bucketArray[8] = nullGuard(tape.getEjectLocation());
73-
bucketArray[9] = nullGuard(tape.getEjectLabel());
74-
bucketArray[10] = nullGuardFromDate(tape.getEjectPending(), DATE_FORMAT);
68+
bucketArray[4] = nullGuardFromDate(tape.getLastVerified(), DATE_FORMAT);
69+
bucketArray[5] = nullGuardToString(tape.getAvailableRawCapacity());
70+
bucketArray[6] = nullGuardToString(tape.getBucketId());
71+
bucketArray[7] = nullGuardToString(storageDomainName(tape));
72+
bucketArray[8] = nullGuardFromDate(tape.getEjectDate(), DATE_FORMAT);
73+
bucketArray[9] = nullGuard(tape.getEjectLocation());
74+
bucketArray[10] = nullGuard(tape.getEjectLabel());
75+
bucketArray[11] = nullGuardFromDate(tape.getEjectPending(), DATE_FORMAT);
7576
formatArray[i++] = bucketArray;
7677
}
7778
return formatArray;

ds3_java_cli/src/test/java/com/spectralogic/ds3cli/Ds3Cli_Test.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2338,14 +2338,14 @@ public void getTapes() throws Exception {
23382338
final String storageDoamin2Name = "Storage domain 2";
23392339

23402340
final String expected =
2341-
"+----------+--------------------------------------+--------+--------------------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n" +
2342-
"| Bar Code | ID | State | Last Modified | Available Raw Capacity | BucketID | Assigned to Storage Domain | Ejection Date | Ejection Location | Ejection Label | Ejection Pending |\n" +
2343-
"+----------+--------------------------------------+--------+--------------------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n" +
2344-
"| 121552L6 | 52741a53-24d5-4391-87a9-9cce703d7ed7 | NORMAL | 2016-06-29T20:24:35.000Z | 2408082046976 | N/A | N/A | N/A | N/A | N/A | N/A |\n" +
2345-
"| 121553L6 | e9e2e2c8-813b-4adf-9ed9-c6f788084656 | NORMAL | 2016-07-18T03:04:30.000Z | 2407684636672 | 5f02264b-b344-4bdd-88bd-7e87133bb0c9 | " + storageDoamin1Name + " | N/A | N/A | N/A | N/A |\n" +
2346-
"| 121555L6 | 8cb037d1-39aa-4f42-b27c-acbdf8b4c3c7 | NORMAL | 2016-06-29T20:18:44.000Z | 2408082046976 | N/A | N/A | N/A | N/A | N/A | N/A |\n" +
2347-
"| 122104L6 | b16a8737-8801-4658-971c-c67d6ae44773 | NORMAL | 2016-07-18T03:07:26.000Z | 2407688830976 | 5f02264b-b344-4bdd-88bd-7e87133bb0c9 | " + storageDoamin2Name + " | N/A | N/A | N/A | N/A |\n" +
2348-
"+----------+--------------------------------------+--------+--------------------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n";
2341+
"+----------+--------------------------------------+--------+--------------------------+---------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n" +
2342+
"| Bar Code | ID | State | Last Modified | Last Verified | Available Raw Capacity | BucketID | Assigned to Storage Domain | Ejection Date | Ejection Location | Ejection Label | Ejection Pending |\n" +
2343+
"+----------+--------------------------------------+--------+--------------------------+---------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n" +
2344+
"| 121552L6 | 52741a53-24d5-4391-87a9-9cce703d7ed7 | NORMAL | 2016-06-29T20:24:35.000Z | N/A | 2408082046976 | N/A | N/A | N/A | N/A | N/A | N/A |\n" +
2345+
"| 121553L6 | e9e2e2c8-813b-4adf-9ed9-c6f788084656 | NORMAL | 2016-07-18T03:04:30.000Z | N/A | 2407684636672 | 5f02264b-b344-4bdd-88bd-7e87133bb0c9 | " + storageDoamin1Name + " | N/A | N/A | N/A | N/A |\n" +
2346+
"| 121555L6 | 8cb037d1-39aa-4f42-b27c-acbdf8b4c3c7 | NORMAL | 2016-06-29T20:18:44.000Z | N/A | 2408082046976 | N/A | N/A | N/A | N/A | N/A | N/A |\n" +
2347+
"| 122104L6 | b16a8737-8801-4658-971c-c67d6ae44773 | NORMAL | 2016-07-18T03:07:26.000Z | N/A | 2407688830976 | 5f02264b-b344-4bdd-88bd-7e87133bb0c9 | " + storageDoamin2Name + " | N/A | N/A | N/A | N/A |\n" +
2348+
"+----------+--------------------------------------+--------+--------------------------+---------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n";
23492349

23502350
final InputStream packet = IOUtils.toInputStream("<Data><Tape>" +
23512351
"<AssignedToStorageDomain>false</AssignedToStorageDomain>" +
@@ -2440,11 +2440,11 @@ public void getTapesWithBucketId() throws Exception {
24402440
"</Data>", "utf-8");
24412441

24422442
final String expected =
2443-
"+----------+--------------------------------------+--------+--------------------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n" +
2444-
"| Bar Code | ID | State | Last Modified | Available Raw Capacity | BucketID | Assigned to Storage Domain | Ejection Date | Ejection Location | Ejection Label | Ejection Pending |\n" +
2445-
"+----------+--------------------------------------+--------+--------------------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n" +
2446-
"| 121552L6 | 52741a53-24d5-4391-87a9-9cce703d7ed7 | NORMAL | 2016-06-29T20:24:35.000Z | 2408082046976 | " + bucketId.toLowerCase() + " | N/A | N/A | N/A | N/A | N/A |\n" +
2447-
"+----------+--------------------------------------+--------+--------------------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n";
2443+
"+----------+--------------------------------------+--------+--------------------------+---------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n" +
2444+
"| Bar Code | ID | State | Last Modified | Last Verified | Available Raw Capacity | BucketID | Assigned to Storage Domain | Ejection Date | Ejection Location | Ejection Label | Ejection Pending |\n" +
2445+
"+----------+--------------------------------------+--------+--------------------------+---------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n" +
2446+
"| 121552L6 | 52741a53-24d5-4391-87a9-9cce703d7ed7 | NORMAL | 2016-06-29T20:24:35.000Z | N/A | 2408082046976 | " + bucketId.toLowerCase() + " | N/A | N/A | N/A | N/A | N/A |\n" +
2447+
"+----------+--------------------------------------+--------+--------------------------+---------------+------------------------+--------------------------------------+----------------------------+---------------+-------------------+----------------+------------------+\n";
24482448

24492449
final TapeList tapes = XmlOutput.fromXml(packet, TapeList.class);
24502450

0 commit comments

Comments
 (0)