Lint nits

Author: jdalton

src/commands/optimize/cmd-optimize.test.mts

@@ -33,11 +33,21 @@ const pnpmFixtureDir = path.join(fixtureBaseDir, PNPM)
 async function revertFixtureChanges() {
   // Reset only the package.json and pnpm-lock.yaml files that tests modify.
   try {
+    // Git needs the paths relative to the repository root.
+    const relativePackageJson = path.relative(
+      process.cwd(),
+      path.join(pnpmFixtureDir, PACKAGE_JSON),
+    )
+    const relativePnpmLock = path.relative(
+      process.cwd(),
+      path.join(pnpmFixtureDir, PNPM_LOCK_YAML),
+    )
+
     await spawn(
       'git',
-      ['checkout', 'HEAD', '--', PACKAGE_JSON, PNPM_LOCK_YAML],
+      ['checkout', 'HEAD', '--', relativePackageJson, relativePnpmLock],
       {
-        cwd: pnpmFixtureDir,
+        cwd: process.cwd(),
         stdio: 'ignore',
       },
     )

src/test/json-output-validation.mts

@@ -21,7 +21,9 @@ export type SocketJsonError = {
   code?: number
 }
 
-export type SocketJsonResponse<T = unknown> = SocketJsonSuccess<T> | SocketJsonError
+export type SocketJsonResponse<T = unknown> =
+  | SocketJsonSuccess<T>
+  | SocketJsonError
 
 /**
  * Validates that a string contains valid JSON matching Socket CLI response format.
@@ -31,7 +33,7 @@ export type SocketJsonResponse<T = unknown> = SocketJsonSuccess<T> | SocketJsonE
  */
 export function validateSocketJson<T = unknown>(
   jsonString: string,
-  expectedExitCode: number
+  expectedExitCode: number,
 ): SocketJsonResponse<T> {
   let parsed: any
 
@@ -44,29 +46,41 @@ export function validateSocketJson<T = unknown>(
 
   // Check for required ok field.
   if (typeof parsed.ok !== 'boolean') {
-    throw new Error(`JSON output missing required 'ok' boolean field: ${jsonString}`)
+    throw new Error(
+      `JSON output missing required 'ok' boolean field: ${jsonString}`,
+    )
   }
 
   // Validate based on exit code expectation.
   if (expectedExitCode === 0) {
     if (parsed.ok !== true) {
-      throw new Error(`JSON output 'ok' should be true when exit code is 0: ${jsonString}`)
+      throw new Error(
+        `JSON output 'ok' should be true when exit code is 0: ${jsonString}`,
+      )
     }
     // Success response must have data field.
     if (parsed.data === undefined || parsed.data === null) {
-      throw new Error(`JSON output missing required 'data' field when ok is true: ${jsonString}`)
+      throw new Error(
+        `JSON output missing required 'data' field when ok is true: ${jsonString}`,
+      )
     }
   } else {
     if (parsed.ok !== false) {
-      throw new Error(`JSON output 'ok' should be false when exit code is non-zero: ${jsonString}`)
+      throw new Error(
+        `JSON output 'ok' should be false when exit code is non-zero: ${jsonString}`,
+      )
     }
     // Error response must have message field.
     if (typeof parsed.message !== 'string' || parsed.message.length === 0) {
-      throw new Error(`JSON output missing required 'message' field when ok is false: ${jsonString}`)
+      throw new Error(
+        `JSON output missing required 'message' field when ok is false: ${jsonString}`,
+      )
     }
     // If code exists, it must be a number.
     if (parsed.code !== undefined && typeof parsed.code !== 'number') {
-      throw new Error(`JSON output 'code' field must be a number: ${jsonString}`)
+      throw new Error(
+        `JSON output 'code' field must be a number: ${jsonString}`,
+      )
     }
   }
 
@@ -77,7 +91,7 @@ export function validateSocketJson<T = unknown>(
  * Helper to check if response is a success response.
  */
 export function isSocketJsonSuccess<T = unknown>(
-  response: SocketJsonResponse<T>
+  response: SocketJsonResponse<T>,
 ): response is SocketJsonSuccess<T> {
   return response.ok === true
 }
@@ -86,7 +100,7 @@ export function isSocketJsonSuccess<T = unknown>(
  * Helper to check if response is an error response.
  */
 export function isSocketJsonError<T = unknown>(
-  response: SocketJsonResponse<T>
+  response: SocketJsonResponse<T>,
 ): response is SocketJsonError {
   return response.ok === false
-}
+}

src/test/mocks/socket-auth.mts

@@ -70,7 +70,9 @@ export function mockConfigStorage() {
 /**
  * Mock API client with authentication.
  */
-export function mockAuthenticatedApiClient(options?: { isAuthenticated?: boolean }) {
+export function mockAuthenticatedApiClient(options?: {
+  isAuthenticated?: boolean
+}) {
   const { isAuthenticated = true } = options || {}
 
   return {
@@ -79,11 +81,11 @@ export function mockAuthenticatedApiClient(options?: { isAuthenticated?: boolean
     setToken: vi.fn(),
     clearToken: vi.fn(),
     validateToken: vi.fn().mockResolvedValue(isAuthenticated),
-    getOrganizations: vi.fn().mockResolvedValue(
-      isAuthenticated
-        ? [{ id: MOCK_ORG_ID, name: MOCK_ORG_NAME }]
-        : []
-    ),
+    getOrganizations: vi
+      .fn()
+      .mockResolvedValue(
+        isAuthenticated ? [{ id: MOCK_ORG_ID, name: MOCK_ORG_NAME }] : [],
+      ),
   }
 }
 
@@ -132,9 +134,13 @@ export function setupLoginMocks(options?: {
   const { authenticated = false, loginShouldSucceed = true } = options || {}
 
   const configMock = mockConfigStorage()
-  const apiClientMock = mockAuthenticatedApiClient({ isAuthenticated: authenticated })
+  const apiClientMock = mockAuthenticatedApiClient({
+    isAuthenticated: authenticated,
+  })
   const browserMock = mockBrowserOpener()
-  const authFlowMock = mockInteractiveLogin({ shouldSucceed: loginShouldSucceed })
+  const authFlowMock = mockInteractiveLogin({
+    shouldSucceed: loginShouldSucceed,
+  })
 
   // Pre-populate config if authenticated.
   if (authenticated) {
@@ -156,4 +162,4 @@ export function setupLoginMocks(options?: {
       expect(configMock.unset).toHaveBeenCalledWith('apiToken')
     },
   }
-}
+}