style: apply auto-fix formatting changes

jdalton · jdalton · commit 352d2b12586b · 2025-10-29T13:45:41.000-04:00
Apply Biome formatting fixes across test files and source files.
Includes cleanup of unused imports, consistent code formatting,
and standardization of code style.
diff --git a/packages/cli/scripts/lint.mjs b/packages/cli/scripts/lint.mjs
@@ -136,7 +136,10 @@ function filterLintableFiles(files) {
     }
 
     // Filter out fixture files (third-party test fixtures should not be linted).
-    if (file.includes('/test/fixtures/') || file.includes('/test\\fixtures\\')) {
+    if (
+      file.includes('/test/fixtures/') ||
+      file.includes('/test\\fixtures\\')
+    ) {
       return false
     }
 
diff --git a/packages/cli/src/commands/fix/pull-request.test.mts b/packages/cli/src/commands/fix/pull-request.test.mts
@@ -1,5 +1,3 @@
-import { RequestError } from '@octokit/request-error'
-
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 import { openSocketFixPr } from './pull-request.mts'
diff --git a/packages/cli/src/commands/patch/output-patch-info-result.mts b/packages/cli/src/commands/patch/output-patch-info-result.mts
@@ -74,7 +74,9 @@ export async function outputPatchInfoResult(
           logger.log(`\n${vuln.description}`)
         }
         if (vuln.patchExplanation) {
-          logger.log(`\n${mdKeyValue('Patch Explanation', vuln.patchExplanation)}`)
+          logger.log(
+            `\n${mdKeyValue('Patch Explanation', vuln.patchExplanation)}`,
+          )
         }
         logger.log('')
       }
diff --git a/packages/cli/src/commands/patch/output-patch-list-result.mts b/packages/cli/src/commands/patch/output-patch-list-result.mts
@@ -130,7 +130,9 @@ export async function outputPatchListResult(
       }
       logger.log('')
     }
-    logger.log(`${mdKeyValue('Legend', '[✓] Applied | [○] Downloaded | [✗] Failed')}`)
+    logger.log(
+      `${mdKeyValue('Legend', '[✓] Applied | [○] Downloaded | [✗] Failed')}`,
+    )
     return
   }
 
diff --git a/packages/cli/src/commands/patch/output-patch-status-result.mts b/packages/cli/src/commands/patch/output-patch-status-result.mts
@@ -95,7 +95,12 @@ export async function outputPatchStatusResult(
     }
 
     // Legend.
-    logger.log(mdKeyValue('Legend', '[✓] Applied | [○] Downloaded | [✗] Failed | [?] Unknown'))
+    logger.log(
+      mdKeyValue(
+        'Legend',
+        '[✓] Applied | [○] Downloaded | [✗] Failed | [?] Unknown',
+      ),
+    )
 
     return
   }
diff --git a/packages/cli/src/commands/scan/cmd-scan-create.mts b/packages/cli/src/commands/scan/cmd-scan-create.mts
@@ -288,7 +288,10 @@ async function run(
 
   // Validate severity value if provided.
   const validSeverities = ['info', 'low', 'moderate', 'high', 'critical']
-  if (reachMinSeverity && !validSeverities.includes(reachMinSeverity.toLowerCase())) {
+  if (
+    reachMinSeverity &&
+    !validSeverities.includes(reachMinSeverity.toLowerCase())
+  ) {
     throw new Error(
       `Invalid severity: "${reachMinSeverity}". Valid values are: ${joinAnd(validSeverities)}`,
     )
diff --git a/packages/cli/src/commands/scan/cmd-scan-reach.mts b/packages/cli/src/commands/scan/cmd-scan-reach.mts
@@ -161,7 +161,10 @@ async function run(
 
   // Validate severity value if provided.
   const validSeverities = ['info', 'low', 'moderate', 'high', 'critical']
-  if (reachMinSeverity && !validSeverities.includes(reachMinSeverity.toLowerCase())) {
+  if (
+    reachMinSeverity &&
+    !validSeverities.includes(reachMinSeverity.toLowerCase())
+  ) {
     throw new Error(
       `Invalid severity: "${reachMinSeverity}". Valid values are: ${joinAnd(validSeverities)}`,
     )
diff --git a/packages/cli/src/commands/self-update/cmd-self-update.test.mts b/packages/cli/src/commands/self-update/cmd-self-update.test.mts
@@ -71,10 +71,7 @@ import {
 
 import { getIpcStubPath } from '@socketsecurity/lib/ipc'
 
-import {
-  canSelfUpdate,
-  isSeaBinary,
-} from '../../utils/executable/detect.mjs'
+import { isSeaBinary } from '../../utils/executable/detect.mjs'
 import { clearQuarantine, ensureExecutable } from '../../utils/process/os.mjs'
 import { handleSelfUpdate } from './handle-self-update.mts'
 
diff --git a/packages/cli/src/utils/git/github-provider.mts b/packages/cli/src/utils/git/github-provider.mts
@@ -179,13 +179,7 @@ export class GitHubProvider implements PrProvider {
   }
 
   async listPrs(options: ListPrsOptions): Promise<PrMatch[]> {
-    const {
-      author,
-      ghsaId,
-      owner,
-      repo,
-      states: statesValue = 'all',
-    } = options
+    const { author, ghsaId, owner, repo, states: statesValue = 'all' } = options
     const checkAuthor = isNonEmptyString(author)
     const octokitGraphql = getOctokitGraphql()
     const matches: PrMatch[] = []
diff --git a/packages/cli/src/utils/git/gitlab-provider.mts b/packages/cli/src/utils/git/gitlab-provider.mts
@@ -138,13 +138,7 @@ export class GitLabProvider implements PrProvider {
   }
 
   async listPrs(options: ListPrsOptions): Promise<PrMatch[]> {
-    const {
-      author,
-      ghsaId,
-      owner,
-      repo,
-      states: statesValue = 'all',
-    } = options
+    const { author, ghsaId, owner, repo, states: statesValue = 'all' } = options
     const checkAuthor = isNonEmptyString(author)
     const matches: PrMatch[] = []
     const projectId = `${owner}/${repo}`
@@ -214,9 +208,7 @@ export class GitLabProvider implements PrProvider {
       // GitLab requires project ID to delete a branch.
       // Since we don't have it in this method, we can't delete.
       // This is a limitation of the current interface design.
-      debug(
-        `mr: cannot delete branch ${branch} - need project ID in interface`,
-      )
+      debug(`mr: cannot delete branch ${branch} - need project ID in interface`)
       return false
     } catch (e) {
       debug(formatErrorWithDetail(`mr: failed to delete branch ${branch}`, e))
@@ -251,9 +243,7 @@ export class GitLabProvider implements PrProvider {
 /**
  * Maps GitLab merge request state to common state.
  */
-function mapGitLabState(
-  state: string,
-): 'open' | 'closed' | 'merged' {
+function mapGitLabState(state: string): 'open' | 'closed' | 'merged' {
   if (state === 'opened') {
     return 'open'
   }
@@ -266,9 +256,7 @@ function mapGitLabState(
 /**
  * Maps GitLab merge request state to uppercase common state.
  */
-function mapGitLabStateToUpper(
-  state: string,
-): 'OPEN' | 'CLOSED' | 'MERGED' {
+function mapGitLabStateToUpper(state: string): 'OPEN' | 'CLOSED' | 'MERGED' {
   if (state === 'opened') {
     return 'OPEN'
   }
@@ -281,9 +269,7 @@ function mapGitLabStateToUpper(
 /**
  * Maps common state to GitLab state.
  */
-function mapStateToGitLab(
-  state: string,
-): 'opened' | 'closed' | 'merged' {
+function mapStateToGitLab(state: string): 'opened' | 'closed' | 'merged' {
   const lower = state.toLowerCase()
   if (lower === 'open') {
     return 'opened'
@@ -297,9 +283,7 @@ function mapStateToGitLab(
 /**
  * Maps GitLab merge_status to common merge state status.
  */
-function mapGitLabMergeStatus(
-  status: string,
-): MergeStateStatus {
+function mapGitLabMergeStatus(status: string): MergeStateStatus {
   // GitLab merge_status values:
   // - can_be_merged: clean, no conflicts
   // - cannot_be_merged: has conflicts
diff --git a/packages/cli/src/utils/git/providers.test.mts b/packages/cli/src/utils/git/providers.test.mts
@@ -3,7 +3,6 @@ import path from 'node:path'
 
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
-import { createPrProvider } from './provider-factory.mts'
 import { GitHubProvider } from './github-provider.mts'
 import { GitLabProvider } from './gitlab-provider.mts'
 
@@ -25,19 +24,17 @@ vi.mock('./operations.mts', () => ({
 }))
 
 vi.mock('@gitbeaker/rest', () => ({
-  Gitlab: vi.fn().mockImplementation(function () {
-    return {
-      MergeRequests: {
-        create: vi.fn(),
-        show: vi.fn(),
-        rebase: vi.fn(),
-        all: vi.fn(),
-      },
-      MergeRequestNotes: {
-        create: vi.fn(),
-      },
-    }
-  }),
+  Gitlab: vi.fn().mockImplementation(() => ({
+    MergeRequests: {
+      create: vi.fn(),
+      show: vi.fn(),
+      rebase: vi.fn(),
+      all: vi.fn(),
+    },
+    MergeRequestNotes: {
+      create: vi.fn(),
+    },
+  })),
 }))
 
 describe('provider-factory', () => {
diff --git a/packages/cli/src/utils/npm/config.test.mts b/packages/cli/src/utils/npm/config.test.mts
@@ -11,9 +11,7 @@ const { MockNpmConfig, mockNpmConfigInstance } = vi.hoisted(() => {
     },
   }
 
-  const MockNpmConfig = vi.fn().mockImplementation(function () {
-    return mockNpmConfigInstance
-  })
+  const MockNpmConfig = vi.fn().mockImplementation(() => mockNpmConfigInstance)
 
   return { MockNpmConfig, mockNpmConfigInstance }
 })
@@ -137,12 +135,10 @@ describe('npm-config utilities', () => {
     it('calls config.load()', async () => {
       const mockLoad = vi.fn().mockResolvedValue(undefined)
       vi.mocked((await import('@npmcli/config')).default).mockImplementation(
-        (function () {
-          return {
-            load: mockLoad,
-            flat: { test: 'value' },
-          }
-        }) as any,
+        (() => ({
+          load: mockLoad,
+          flat: { test: 'value' },
+        })) as any,
       )
 
       await getNpmConfig()
diff --git a/packages/cli/src/utils/output/markdown.mts b/packages/cli/src/utils/output/markdown.mts
@@ -37,7 +37,7 @@
  * mdHeader('Title') // '# Title'
  * mdHeader('Subtitle', 2) // '## Subtitle'
  */
-export function mdHeader(title: string, level: number = 1): string {
+export function mdHeader(title: string, level = 1): string {
   const headerLevel = Math.max(1, Math.min(6, level))
   return `${'#'.repeat(headerLevel)} ${title}`
 }
@@ -58,7 +58,7 @@ export function mdHeader(title: string, level: number = 1): string {
 export function mdKeyValue(
   label: string,
   value: string | number | undefined,
-  escaped: boolean = false,
+  escaped = false,
 ): string {
   const displayValue = value === undefined ? 'N/A' : String(value)
   const finalValue = escaped
@@ -156,7 +156,7 @@ export function mdError(message: string, cause?: string): string {
 export function mdSection(
   title: string,
   content: string | string[],
-  level: number = 2,
+  level = 2,
 ): string {
   const header = mdHeader(title, level)
   const body = Array.isArray(content) ? content.join('\n') : content
diff --git a/packages/cli/test/fixtures/commands/patch/pnpm/.socket/manifest.json b/packages/cli/test/fixtures/commands/patch/pnpm/.socket/manifest.json
@@ -11,9 +11,7 @@
       },
       "vulnerabilities": {
         "GHSA-76c9-3jph-rj3q": {
-          "cves": [
-            "CVE-2025-7339"
-          ],
+          "cves": ["CVE-2025-7339"],
           "summary": "on-headers is vulnerable to http response header manipulation",
           "severity": "LOW",
           "description": "### Impact\n\nA bug in on-headers versions `< 1.1.0` may result in response headers being inadvertently modified when an array is passed to `response.writeHead()`\n\n### Patches\n\nUsers should upgrade to `1.1.0`\n\n### Workarounds\n\nUses are encouraged to upgrade to `1.1.0`, but this issue can be worked around by passing an object to `response.writeHead()` rather than an array.",
@@ -22,4 +20,4 @@
       }
     }
   }
-}
+}
diff --git a/packages/cli/test/fixtures/commands/patch/pnpm/custom-patches/index.js b/packages/cli/test/fixtures/commands/patch/pnpm/custom-patches/index.js

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,10 @@ function filterLintableFiles(files) {`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`// Filter out fixture files (third-party test fixtures should not be linted).`
`139`		`- if (file.includes('/test/fixtures/') \|\| file.includes('/test\\fixtures\\')) {`
	`139`	`+ if (`
	`140`	`+ file.includes('/test/fixtures/') \|\|`
	`141`	`+ file.includes('/test\\fixtures\\')`
	`142`	`+ ) {`
`140`	`143`	`return false`
`141`	`144`	`}`
`142`	`145`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-import { RequestError } from '@octokit/request-error'`
`2`		`-`
`3`	`1`	`import { beforeEach, describe, expect, it, vi } from 'vitest'`
`4`	`2`
`5`	`3`	`import { openSocketFixPr } from './pull-request.mts'`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,9 @@ export async function outputPatchInfoResult(`
`74`	`74`	logger.log(`\n${vuln.description}`)
`75`	`75`	`}`
`76`	`76`	`if (vuln.patchExplanation) {`
`77`		- logger.log(`\n${mdKeyValue('Patch Explanation', vuln.patchExplanation)}`)
	`77`	`+ logger.log(`
	`78`	+ `\n${mdKeyValue('Patch Explanation', vuln.patchExplanation)}`,
	`79`	`+ )`
`78`	`80`	`}`
`79`	`81`	`logger.log('')`
`80`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,9 @@ export async function outputPatchListResult(`
`130`	`130`	`}`
`131`	`131`	`logger.log('')`
`132`	`132`	`}`
`133`		- logger.log(`${mdKeyValue('Legend', '[✓] Applied \| [○] Downloaded \| [✗] Failed')}`)
	`133`	`+ logger.log(`
	`134`	+ `${mdKeyValue('Legend', '[✓] Applied \| [○] Downloaded \| [✗] Failed')}`,
	`135`	`+ )`
`134`	`136`	`return`
`135`	`137`	`}`
`136`	`138`
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,12 @@ export async function outputPatchStatusResult(`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`// Legend.`
`98`		`- logger.log(mdKeyValue('Legend', '[✓] Applied \| [○] Downloaded \| [✗] Failed \| [?] Unknown'))`
	`98`	`+ logger.log(`
	`99`	`+ mdKeyValue(`
	`100`	`+ 'Legend',`
	`101`	`+ '[✓] Applied \| [○] Downloaded \| [✗] Failed \| [?] Unknown',`
	`102`	`+ ),`
	`103`	`+ )`
`99`	`104`
`100`	`105`	`return`
`101`	`106`	`}`