Skip to content

Players are Disconnected when recieving Death Message with Chat Open (incompatibility with Supplementaries) #267

@Immodial

Description

@Immodial

Minecraft version

1.21.1

Describe the bug

Dying with Chat Open Crashes Game

Steps to reproduce

  1. Play with the Forgified Fabric API.
  2. Install Supplementaries. I tested it without supplementaries and the error doesn't occur, but the error originates from the onScreenRemove function, which is likely not called by Supplementaries.
  3. Place yourself at a Y level high off the ground and die with chat open.
  4. Causes error upon the death packet being received:
[Server thread/INFO][net.minecraft.server.MinecraftServer/]: PlayerName fell from a high place
[Render thread/ERROR][net.minecraft.client.multiplayer.ClientCommonPacketListenerImpl/]: Failed to handle packet ClientboundPlayerCombatKillPacket[playerId=79, message=translation{key='death.fell.accident.generic', args=[empty[style={clickEvent=ClickEvent{action=SUGGEST_COMMAND, value='/tell PlayerName '},hoverEvent=TypedHoverEvent[action=<action show_entity>, value=net.minecraft.network.chat.HoverEvent$EntityTooltipInfo@aff16f4a],insertion=PlayerName}, siblings=[literal{PlayerName}]]]}]
java.lang.NullPointerException: Screen cannot be null
	at java.base/java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]
	at TRANSFORMER/fabric_screen_api_v1@2.0.25+4228281319/net.fabricmc.fabric.api.client.screen.v1.ScreenEvents.remove(ScreenEvents.java:111) ~[fabric-screen-api-v1-2.0.25+4228281319.jar%23428!/:2.0.25+4228281319]
  1. Player is booted back to the multiplayer menu, even in singleplayer.

Logs

latest.log

Additional context

This issue has already been reported to the Supplementaries developers and marked as not an issue on their end, then moved to this Forgified Fabric API issue, but judging by the comments saying that it is still an issue months after its fix I'm assuming issues here aren't reopened and a new one needs to be made.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions