OSHA1stream functionality of RapidCFD needs to be updated to C++11 or many simulations don't run

[klausbu]

The OSHA1stream functionality of RapidCFD needs to be updated to C++11 as this is required by more recent compilers or most simulations don't run!

This was first encountered related to OpenFOAM in 2022 and I ran into the same problem today after installing RapidCFD with AMD GPU support (available here: https://github.com/wtkaczewski/RapidCFD-dev) using ROCm 6.1 (If you are interested in the AMD support, Note: in the bashrc change Clang to hipcc and rename the folder $HOME/RapidCFD/RapidCFD-dev/wmake/rules/linux64Clang/ to $HOME/RapidCFD/RapidCFD-dev/wmake/rules/linux64hipcc/).

When running the tests found here: https://github.com/TonkomoLLC/RapidCFD-Tests, only the icoFoam test works, the others cause the following error:

--> FOAM FATAL IO ERROR: 
error in IOstream "OSHA1stream.sinkFile_" for operation Ostream& operator<<(Ostream&, const word&)

file: OSHA1stream.sinkFile_ at line 0.

    From function IOstream::check(const char*) const
    in file db/IOstreams/IOstreams/IOstream.C at line 99.

This is caused by the OSHA1stream functionality which needs to be updated to C++11.

The fix for OpenFOAM has been provided here: OpenFOAM/OpenFOAM-9@b0c15be but I lack the skills to implement it in RapidCFD.

[klausbu]

The solution is to use the implementation from OpenFOAM 11, just copy-paste / replace the file OSHA1stream.H which resides in /RapidCFD/RapidCFD-dev/src/OpenFOAM/db/IOstreams/hashes/OSHA1stream.H:

https://cpp.openfoam.org/v11/OSHA1stream_8H_source.html

[pure2082]

Thank you very mush, this problem spent me a lot pf time.