fix staticcheck warnings

- use snappy.NewBufferedWriter instead of deprecated NewWriter
- simplify channel receive instead of select with single case
- remove unnecessary nil check before range
- lowercase error string
- check error from startProxyPort before deferring Close
- remove unused struct fields (tgtW, expanded)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: MagicalTux

interco.go

@@ -28,7 +28,9 @@ func interco(c1, c2 net.Conn, compress bool) {
 		defer doClose()
 		if compress {
 			// snappy compression
-			io.Copy(snappy.NewWriter(c1), c2)
+			w := snappy.NewBufferedWriter(c1)
+			io.Copy(w, c2)
+			w.Close()
 		} else {
 			io.Copy(c1, c2)
 		}
@@ -46,7 +48,5 @@ func interco(c1, c2 net.Conn, compress bool) {
 	}()
 
 	// wait for close signal
-	select {
-	case <-cl:
-	}
+	<-cl
 }

login.go

@@ -134,11 +134,9 @@ func (l *loginShells) checkSession() bool {
 
 func (l *loginShells) call(vars map[string]interface{}) {
 	req := make(map[string]interface{})
-	if vars != nil {
-		// duplicate values
-		for k, v := range vars {
-			req[k] = v
-		}
+	// duplicate values
+	for k, v := range vars {
+		req[k] = v
 	}
 	req["client_id"] = clientID
 	if l.session != "" {

shells.go

@@ -155,7 +155,7 @@ func (s *shell) ProxyConnect(port uint16, compress bool, timeout time.Duration)
 		return nil, err
 	}
 	if res[0] != 0 {
-		return nil, errors.New("Connection has failed")
+		return nil, errors.New("connection has failed")
 	}
 	c.SetReadDeadline(time.Time{})
 
@@ -256,6 +256,10 @@ func (s *shell) tryRdp() {
 	c.Close()
 
 	l, err := s.startProxyPort(3389, false)
+	if err != nil {
+		log.Printf("rdp: failed to start proxy port: %s", err)
+		return
+	}
 	defer l.Close()
 
 	addr := l.Addr().(*net.TCPAddr)

snappy.go

@@ -35,9 +35,13 @@ func (s *snappyConn) Read(b []byte) (int, error) {
 
 func (s *snappyConn) Write(b []byte) (int, error) {
 	if s.sw == nil {
-		s.sw = snappy.NewWriter(s.c)
+		s.sw = snappy.NewBufferedWriter(s.c)
 	}
-	return s.sw.Write(b)
+	n, err := s.sw.Write(b)
+	if err != nil {
+		return n, err
+	}
+	return n, s.sw.Flush()
 }
 
 func (s *snappyConn) SetDeadline(t time.Time) error {

spicefyne/control.go

@@ -16,7 +16,6 @@ type control struct {
 	visible         bool
 	parent          *SpiceFyne
 	sidebarPosition string
-	tgtW            float32
 
 	muteIconContainer *fyne.Container
 	sidebar           *fyne.Container

spicefyne/widget.go

@@ -39,8 +39,6 @@ type SpiceFyne struct {
 
 	cursorObj *fyneCursor
 
-	expanded bool
-
 	// focus
 	focused bool