Skip to content

Commit e488898

Browse files
committed
Renames and fixes to stats url. Add test.
1 parent 1d60e66 commit e488898

12 files changed

+228
-220
lines changed

src/ServiceStackIDEA/.idea/workspace.xml

Lines changed: 175 additions & 181 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ServiceStackIDEA/src/main/java/net/servicestack/idea/AddTypeScriptAction.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ public void actionPerformed(AnActionEvent anActionEvent) {
2424
dialog.setLocationRelativeTo(null);
2525
dialog.setSize(dialog.getPreferredSize());
2626
dialog.setResizable(true);
27-
dialog.setTitle("Add TypeScript ServiceStack Reference");
27+
dialog.setTitle("Add TypeScriptConcrete ServiceStack Reference");
2828
PsiElement element = LangDataKeys.PSI_ELEMENT.getData(anActionEvent.getDataContext());
29-
INativeTypesHandler defaultTsNativeTypesHandler = new TypeScriptDefinitionNativeTypesHandler();
29+
INativeTypesHandler defaultTsNativeTypesHandler = new TypeScriptNativeTypesHandler();
3030
if (element != null && element instanceof PsiDirectory) {
3131
PsiDirectory selectedDir = (PsiDirectory)element;
3232
dialog.setSelectedDirectory(selectedDir.getVirtualFile().getPath());

src/ServiceStackIDEA/src/main/java/net/servicestack/idea/AddTypeScriptRefHandler.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import com.intellij.openapi.module.Module;
44
import com.intellij.openapi.vfs.VirtualFileManager;
5-
import com.intellij.util.EnvironmentUtil;
65

76
import java.io.File;
87
import java.io.FileNotFoundException;
@@ -11,7 +10,6 @@
1110
import java.net.URISyntaxException;
1211
import java.util.List;
1312

14-
import static net.servicestack.idea.IDEAUtils.getNativeTypesHandler;
1513
import static net.servicestack.idea.IDEAUtils.refreshFile;
1614

1715
public class AddTypeScriptRefHandler {
@@ -25,8 +23,8 @@ static void handleOk(Module module,
2523
File file = new File(selectedDirectory);
2624
INativeTypesHandler nativeTypesHandler =
2725
definitionsOnly ?
28-
new TypeScriptDefinitionNativeTypesHandler() :
29-
new TypeScriptNativeTypesHandler();
26+
new TypeScriptNativeTypesHandler() :
27+
new TypeScriptConcreteNativeTypesHandler();
3028

3129
String dtoPath = file.getAbsolutePath() + File.separator
3230
+ getDtoFileName(fileName,nativeTypesHandler);

src/ServiceStackIDEA/src/main/java/net/servicestack/idea/Analytics.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public final class Analytics {
1616
public static void SubmitAnonymousAddReferenceUsage(INativeTypesHandler typesHandler) {
1717
PluginSettingsService settings = PluginSettingsService.getInstance();
1818
if(!settings.optOutOfStats) {
19-
final String url = addRefUrl + typesHandler.getTypesLanguage().name();
19+
final String url = addRefUrl + typesHandler.getLanguageUrlName();
2020
final URL[] serviceUrl = {null};
2121
final URLConnection[] responseConnection = {null};
2222
final BufferedReader[] responseReader = {null};

src/ServiceStackIDEA/src/main/java/net/servicestack/idea/BaseNativeTypesHandler.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,14 @@ public URIBuilder getUrl(String baseUrl) throws MalformedURLException, URISyntax
6464
return builder;
6565
}
6666

67-
public static String toParentPath(String path)
68-
{
67+
public static String toParentPath(String path) {
6968
int pos = path.lastIndexOf("/");
7069
if (pos == -1) return "/";
7170
return path.substring(0, pos);
7271
}
72+
73+
@Override
74+
public String getLanguageUrlName() {
75+
return this.getRelativeTypesUrl().substring(6);
76+
}
7377
}

src/ServiceStackIDEA/src/main/java/net/servicestack/idea/IDEAUtils.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import com.intellij.openapi.vfs.LocalFileSystem;
99
import com.intellij.openapi.vfs.VirtualFile;
1010
import com.intellij.openapi.vfs.VirtualFileManager;
11-
import com.intellij.psi.PsiDocumentManager;
1211
import com.intellij.util.PlatformUtils;
1312

1413
import java.io.*;
@@ -102,7 +101,7 @@ public static INativeTypesHandler getDefaultNativeTypesHandler(Module module) {
102101
}
103102

104103
if(PlatformUtils.isWebStorm()) {
105-
return new TypeScriptNativeTypesHandler();
104+
return new TypeScriptConcreteNativeTypesHandler();
106105
}
107106

108107
return new JavaNativeTypesHandler();
@@ -112,8 +111,8 @@ public static INativeTypesHandler getNativeTypesHandler(String fileName) {
112111
INativeTypesHandler result = null;
113112
if(fileName.endsWith(".kt")) result = new KotlinNativeTypesHandler();
114113
if(fileName.endsWith(".java")) result = new JavaNativeTypesHandler();
115-
if(fileName.endsWith(".dtos.ts")) result = new TypeScriptNativeTypesHandler();
116-
if(fileName.endsWith(".dtos.d.ts")) result = new TypeScriptDefinitionNativeTypesHandler();
114+
if(fileName.endsWith(".dtos.ts")) result = new TypeScriptConcreteNativeTypesHandler();
115+
if(fileName.endsWith(".dtos.d.ts")) result = new TypeScriptNativeTypesHandler();
117116
return result;
118117
}
119118
}

src/ServiceStackIDEA/src/main/java/net/servicestack/idea/INativeTypesHandler.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,5 @@ public interface INativeTypesHandler {
1717
List<String> getUpdatedCode(String baseUrl, Map<String, String> options) throws IOException, URISyntaxException;
1818
String getRelativeTypesUrl();
1919
NativeTypesLanguage getTypesLanguage();
20+
String getLanguageUrlName();
2021
}

src/ServiceStackIDEA/src/main/java/net/servicestack/idea/NativeTypesLanguage.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
public enum NativeTypesLanguage {
77
Java,
88
Kotlin,
9-
TypeScript,
10-
TypeScriptDefinition
9+
TypeScriptConcrete,
10+
TypeScript
1111
}
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
package net.servicestack.idea;
2+
3+
/**
4+
* Created by Layoric on 13/05/2016.
5+
*/
6+
public class TypeScriptConcreteNativeTypesHandler extends BaseNativeTypesHandler {
7+
@Override
8+
public String getFileExtension() {
9+
return ".dtos.ts";
10+
}
11+
12+
@Override
13+
public String getRelativeTypesUrl() {
14+
return "types/typescript";
15+
}
16+
17+
@Override
18+
public NativeTypesLanguage getTypesLanguage() {
19+
return NativeTypesLanguage.TypeScriptConcrete;
20+
}
21+
}

src/ServiceStackIDEA/src/main/java/net/servicestack/idea/TypeScriptDefinitionNativeTypesHandler.java

Lines changed: 0 additions & 21 deletions
This file was deleted.

0 commit comments

Comments
 (0)