Skip to content

Commit 8136beb

Browse files
committed
Switch to ByteArrayOutputStream to remove Apache Http dependency
1 parent 97b00eb commit 8136beb

File tree

2 files changed

+7
-13
lines changed
  • src/AndroidClient
    • android/src/main/java/net/servicestack/client
    • client/src/main/java/net/servicestack/client

2 files changed

+7
-13
lines changed

src/AndroidClient/android/src/main/java/net/servicestack/client/Utils.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,9 @@
88
import com.google.gson.JsonObject;
99
import com.google.gson.JsonParseException;
1010

11-
import org.apache.http.util.ByteArrayBuffer;
12-
1311
import java.io.BufferedInputStream;
1412
import java.io.BufferedReader;
13+
import java.io.ByteArrayOutputStream;
1514
import java.io.IOException;
1615
import java.io.InputStream;
1716
import java.io.InputStreamReader;
@@ -507,15 +506,13 @@ public static byte[] readBytesToEnd(HttpURLConnection response){
507506
}
508507

509508
public static byte[] readBytesToEnd(InputStream stream) throws IOException {
510-
511-
ByteArrayBuffer bytes = new ByteArrayBuffer(1024);
512-
509+
ByteArrayOutputStream bytes = new ByteArrayOutputStream(1024);
513510
final BufferedInputStream bufferedStream = new BufferedInputStream(stream, 8192);
514511
try {
515512
final byte[] buffer = new byte[1024];
516513
int bytesRead = 0;
517514
while ((bytesRead = bufferedStream.read(buffer)) > 0) {
518-
bytes.append(buffer, 0, bytesRead);
515+
bytes.write(buffer, 0, bytesRead);
519516
}
520517
return bytes.toByteArray();
521518
} finally {

src/AndroidClient/client/src/main/java/net/servicestack/client/Utils.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,11 @@
88
import com.google.gson.JsonObject;
99
import com.google.gson.JsonParseException;
1010

11-
import org.apache.http.util.ByteArrayBuffer;
11+
import net.servicestack.func.Function;
1212

1313
import java.io.BufferedInputStream;
1414
import java.io.BufferedReader;
15+
import java.io.ByteArrayOutputStream;
1516
import java.io.IOException;
1617
import java.io.InputStream;
1718
import java.io.InputStreamReader;
@@ -31,8 +32,6 @@
3132
import java.util.Map;
3233
import java.util.UUID;
3334

34-
import net.servicestack.func.Function;
35-
3635
import static net.servicestack.func.Func.last;
3736

3837
// Generic Utils
@@ -507,15 +506,13 @@ public static byte[] readBytesToEnd(HttpURLConnection response){
507506
}
508507

509508
public static byte[] readBytesToEnd(InputStream stream) throws IOException {
510-
511-
ByteArrayBuffer bytes = new ByteArrayBuffer(1024);
512-
509+
ByteArrayOutputStream bytes = new ByteArrayOutputStream(1024);
513510
final BufferedInputStream bufferedStream = new BufferedInputStream(stream, 8192);
514511
try {
515512
final byte[] buffer = new byte[1024];
516513
int bytesRead = 0;
517514
while ((bytesRead = bufferedStream.read(buffer)) > 0) {
518-
bytes.append(buffer, 0, bytesRead);
515+
bytes.write(buffer, 0, bytesRead);
519516
}
520517
return bytes.toByteArray();
521518
} finally {

0 commit comments

Comments
 (0)