trace should include snapshot elements

Author: rcholic

sentience/agent.py

@@ -198,29 +198,16 @@ def act(  # noqa: C901
 
                 # Emit snapshot trace event if tracer is enabled
                 if self.tracer:
-                    # Include element data for live overlay visualization
-                    # Use filtered_elements for overlay (only relevant elements)
-                    elements_data = [
-                        {
-                            "id": el.id,
-                            "bbox": {
-                                "x": el.bbox.x,
-                                "y": el.bbox.y,
-                                "width": el.bbox.width,
-                                "height": el.bbox.height,
-                            },
-                            "role": el.role,
-                            "text": el.text[:50] if el.text else "",  # Truncate for brevity
-                        }
-                        for el in filtered_elements[:50]  # Limit to first 50 for performance
-                    ]
+                    # Include ALL elements with full data for DOM tree display
+                    # Use snap.elements (all elements) not filtered_elements
+                    elements_data = [el.model_dump() for el in snap.elements]
 
                     # Build snapshot event data
                     snapshot_data = {
                         "url": snap.url,
                         "element_count": len(snap.elements),
                         "timestamp": snap.timestamp,
-                        "elements": elements_data,  # Add element data for overlay
+                        "elements": elements_data,  # Full element data for DOM tree
                     }
 
                     # Always include screenshot in trace event for studio viewer compatibility
@@ -983,29 +970,16 @@ async def act(  # noqa: C901
 
                 # Emit snapshot trace event if tracer is enabled
                 if self.tracer:
-                    # Include element data for live overlay visualization
-                    # Use filtered_elements for overlay (only relevant elements)
-                    elements_data = [
-                        {
-                            "id": el.id,
-                            "bbox": {
-                                "x": el.bbox.x,
-                                "y": el.bbox.y,
-                                "width": el.bbox.width,
-                                "height": el.bbox.height,
-                            },
-                            "role": el.role,
-                            "text": el.text[:50] if el.text else "",  # Truncate for brevity
-                        }
-                        for el in filtered_elements[:50]  # Limit to first 50 for performance
-                    ]
+                    # Include ALL elements with full data for DOM tree display
+                    # Use snap.elements (all elements) not filtered_elements
+                    elements_data = [el.model_dump() for el in snap.elements]
 
                     # Build snapshot event data
                     snapshot_data = {
                         "url": snap.url,
                         "element_count": len(snap.elements),
                         "timestamp": snap.timestamp,
-                        "elements": elements_data,  # Add element data for overlay
+                        "elements": elements_data,  # Full element data for DOM tree
                     }
 
                     # Always include screenshot in trace event for studio viewer compatibility

sentience/trace_indexing/indexer.py

@@ -58,13 +58,18 @@ def _compute_snapshot_digest(snapshot_data: dict[str, Any]) -> str:
     # Canonicalize elements
     canonical_elements = []
     for elem in elements:
+        # Extract is_primary and is_clickable from visual_cues if present
+        visual_cues = elem.get("visual_cues", {})
+        is_primary = visual_cues.get("is_primary", False) if isinstance(visual_cues, dict) else elem.get("is_primary", False)
+        is_clickable = visual_cues.get("is_clickable", False) if isinstance(visual_cues, dict) else elem.get("is_clickable", False)
+        
         canonical_elem = {
             "id": elem.get("id"),
             "role": elem.get("role", ""),
             "text_norm": _normalize_text(elem.get("text")),
             "bbox": _round_bbox(elem.get("bbox", {"x": 0, "y": 0, "width": 0, "height": 0})),
-            "is_primary": elem.get("is_primary", False),
-            "is_clickable": elem.get("is_clickable", False),
+            "is_primary": is_primary,
+            "is_clickable": is_clickable,
         }
         canonical_elements.append(canonical_elem)