fix tests

Author: rcholic

sentience/cloud_tracing.py

@@ -149,6 +149,13 @@ def close(
         # Close file first
         self._trace_file.close()
 
+        # Ensure file exists and has content before proceeding
+        if not self._path.exists() or self._path.stat().st_size == 0:
+            # No events were emitted, nothing to upload
+            if self.logger:
+                self.logger.warning("No trace events to upload (file is empty or missing)")
+            return
+
         # Generate index after closing file
         self._generate_index()
 

tests/test_cloud_tracing.py

@@ -104,10 +104,12 @@ def test_cloud_trace_sink_emit_after_close_raises(self):
         """Test CloudTraceSink raises error when emitting after close."""
         upload_url = "https://test.com/upload"
         sink = CloudTraceSink(upload_url, run_id="test-run-789")
+        # Emit at least one event so file exists
+        sink.emit({"v": 1, "type": "test", "seq": 1})
         sink.close()
 
         with pytest.raises(RuntimeError, match="CloudTraceSink is closed"):
-            sink.emit({"v": 1, "type": "test", "seq": 1})
+            sink.emit({"v": 1, "type": "test", "seq": 2})
 
     def test_cloud_trace_sink_context_manager(self):
         """Test CloudTraceSink works as context manager."""
@@ -408,7 +410,9 @@ def test_create_tracer_pro_tier_success(self, capsys):
 
                 # Verify tracer works
                 assert tracer.run_id == "test-run"
-                assert isinstance(tracer.sink, CloudTraceSink)
+                # Check if sink is CloudTraceSink (it should be)
+                from sentience.cloud_tracing import CloudTraceSink
+                assert isinstance(tracer.sink, CloudTraceSink), f"Expected CloudTraceSink, got {type(tracer.sink)}"
                 assert tracer.sink.run_id == "test-run"  # Verify run_id is passed
 
                 # Cleanup

tests/test_trace_file_manager_extract_stats.py

@@ -21,10 +21,11 @@ def test_extract_stats_empty_events():
 
 def test_extract_stats_with_run_start_and_end():
     """Test extract_stats calculates duration from run_start and run_end."""
+    from datetime import timedelta
+
     start_time = datetime.now(timezone.utc)
-    end_time = datetime.now(timezone.utc)
-    # Make end_time 5 seconds later
-    end_time = end_time.replace(second=end_time.second + 5)
+    # Make end_time 5 seconds later using timedelta
+    end_time = start_time + timedelta(seconds=5)
 
     events = [
         {