fix step_end issue for failed run

Author: SentienceDEV

sentience/agent_runtime.py

@@ -583,7 +583,7 @@ def assert_done(
             True if task is complete (assertion passed), False otherwise
         """
         # Convenience wrapper for assert_ with required=True
-        ok = self.assert_(predicate, label=label, required=True)
+        ok = self.assertTrue(predicate, label=label, required=True)
         if ok:
             self._task_done = True
             self._task_done_label = label

sentience/trace_event_builder.py

@@ -116,7 +116,8 @@ def build_step_end_event(
             pre_data["elements"] = pre_elements
 
         # Build verify data with assertions if provided
-        final_verify_data = verify_data.copy()
+        # Handle None verify_data for failed steps
+        final_verify_data = verify_data.copy() if verify_data else {}
         if assertions:
             # Ensure signals dict exists
             if "signals" not in final_verify_data:

tests/test_trace_event_builder.py

@@ -273,3 +273,50 @@ def test_build_step_end_event_empty_elements():
     # Should have elements field but it's empty
     assert "elements" in result["pre"]
     assert len(result["pre"]["elements"]) == 0
+
+
+def test_build_step_end_event_with_none_verify_data():
+    """Test step_end event building when verify_data is None (failed steps).
+
+    This test ensures that failed steps can emit step_end events even when
+    verify_data is None, which happens when a step fails before verification.
+    """
+    llm_data = {
+        "response_text": "click(123)",
+        "response_hash": "sha256:abc123",
+        "usage": {"prompt_tokens": 100, "completion_tokens": 10, "total_tokens": 110},
+    }
+
+    exec_data = {
+        "success": False,
+        "action": "error",
+        "outcome": "Element not found",
+        "duration_ms": 500,
+    }
+
+    # verify_data is None for failed steps
+    result = TraceEventBuilder.build_step_end_event(
+        step_id="step-1",
+        step_index=1,
+        goal="Click the button",
+        attempt=2,
+        pre_url="http://example.com/page1",
+        post_url="http://example.com/page1",
+        snapshot_digest="sha256:digest123",
+        llm_data=llm_data,
+        exec_data=exec_data,
+        verify_data=None,  # None for failed steps
+    )
+
+    # Verify basic structure
+    assert result["v"] == 1
+    assert result["step_id"] == "step-1"
+    assert result["step_index"] == 1
+    assert result["attempt"] == 2
+
+    # Verify exec shows failure
+    assert result["exec"]["success"] is False
+    assert result["exec"]["action"] == "error"
+
+    # Verify should be empty dict when verify_data is None
+    assert result["verify"] == {}