Skip to content

Commit 1c5f069

Browse files
committed
fix tests
1 parent d71c96d commit 1c5f069

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

tests/test_video_recording.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def test_video_recording_basic():
2121

2222
try:
2323
browser.page.goto("https://example.com")
24-
browser.page.wait_for_load_state("networkidle")
24+
browser.page.wait_for_load_state("domcontentloaded")
2525

2626
video_path = browser.close()
2727

@@ -52,7 +52,7 @@ def test_video_recording_custom_resolution():
5252

5353
try:
5454
browser.page.goto("https://example.com")
55-
browser.page.wait_for_load_state("networkidle")
55+
browser.page.wait_for_load_state("domcontentloaded")
5656

5757
video_path = browser.close()
5858

@@ -74,7 +74,7 @@ def test_video_recording_custom_output_path():
7474

7575
try:
7676
browser.page.goto("https://example.com")
77-
browser.page.wait_for_load_state("networkidle")
77+
browser.page.wait_for_load_state("domcontentloaded")
7878

7979
video_path = browser.close(output_path=str(custom_path))
8080

@@ -97,7 +97,7 @@ def test_video_recording_nested_output_path():
9797

9898
try:
9999
browser.page.goto("https://example.com")
100-
browser.page.wait_for_load_state("networkidle")
100+
browser.page.wait_for_load_state("domcontentloaded")
101101

102102
video_path = browser.close(output_path=str(nested_path))
103103

@@ -139,7 +139,7 @@ def test_video_recording_directory_auto_created():
139139

140140
try:
141141
browser.page.goto("https://example.com")
142-
browser.page.wait_for_load_state("networkidle")
142+
browser.page.wait_for_load_state("domcontentloaded")
143143

144144
video_path = browser.close()
145145

@@ -166,7 +166,7 @@ def test_video_recording_with_pathlib():
166166

167167
try:
168168
browser.page.goto("https://example.com")
169-
browser.page.wait_for_load_state("networkidle")
169+
browser.page.wait_for_load_state("domcontentloaded")
170170

171171
video_path = browser.close(output_path=output_path) # Pass Path object
172172

@@ -219,7 +219,7 @@ def test_video_recording_default_resolution():
219219

220220
try:
221221
browser.page.goto("https://example.com")
222-
browser.page.wait_for_load_state("networkidle")
222+
browser.page.wait_for_load_state("domcontentloaded")
223223
browser.close()
224224
except Exception:
225225
browser.close()
@@ -234,7 +234,7 @@ def test_video_recording_with_context_manager():
234234
# Use context manager WITHOUT calling close() manually
235235
with SentienceBrowser(headless=True, record_video_dir=str(video_dir)) as browser:
236236
browser.page.goto("https://example.com")
237-
browser.page.wait_for_load_state("networkidle")
237+
browser.page.wait_for_load_state("domcontentloaded")
238238
# Don't call browser.close() - let context manager handle it
239239

240240
# Verify video was created after context manager exits

0 commit comments

Comments
 (0)