Skip to content

Commit 3aaf2ba

Browse files
committed
minor EasyCorp#7429 Fallback to entity FQCN short name if entity translation feature is n… (michaelKaefer)
This PR was merged into the 4.x branch. Discussion ---------- Fallback to entity FQCN short name if entity translation feature is n… …ot used Sorry but this is another fix for if the label is `null` in `linkToCrud()` and entity translation is not activated. I didn't test enough. Commits ------- b594f4b Fallback to entity FQCN short name if entity translation feature is not used
2 parents fd1bdef + b594f4b commit 3aaf2ba

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

src/Factory/MenuFactory.php

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,14 @@ private function buildMenuItem(MenuItemDto $menuItemDto, array $subItems, string
109109
{
110110
if (!$menuItemDto->getLabel() instanceof TranslatableInterface) {
111111
$label = $menuItemDto->getLabel();
112-
if (null === $label && MenuItemDto::TYPE_CRUD === $menuItemDto->getType() && $isUseEntityTranslations) {
113-
$label = Action::INDEX === $menuItemDto->getRouteParameters()[EA::CRUD_ACTION]
114-
? $this->entityTranslationIdGenerator->generateForEntity($menuItemDto->getRouteParameters()[EA::ENTITY_FQCN], false)
115-
: $this->entityTranslationIdGenerator->generateForEntity($menuItemDto->getRouteParameters()[EA::ENTITY_FQCN], true);
112+
if (null === $label && MenuItemDto::TYPE_CRUD === $menuItemDto->getType()) {
113+
if ($isUseEntityTranslations) {
114+
$label = Action::INDEX === $menuItemDto->getRouteParameters()[EA::CRUD_ACTION]
115+
? $this->entityTranslationIdGenerator->generateForEntity($menuItemDto->getRouteParameters()[EA::ENTITY_FQCN], false)
116+
: $this->entityTranslationIdGenerator->generateForEntity($menuItemDto->getRouteParameters()[EA::ENTITY_FQCN], true);
117+
} else {
118+
$label = basename(str_replace('\\', '/', $menuItemDto->getRouteParameters()[EA::ENTITY_FQCN]));
119+
}
116120
} else {
117121
$label = '' === $label ? $label : t($label, $menuItemDto->getTranslationParameters(), $translationDomain);
118122
}

0 commit comments

Comments
 (0)